Are types considered breaking changes? #20015
Unanswered
koterpillar
asked this question in
Q&A
Replies: 1 comment
-
Yes, it's possible, for example, when encountering a schema validation error.
We can refine it using function overloading, but it only makes sense when callback isn't provided (i.e., webpack({ /* options */ })). |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
#19711 changed the return type of
webpack
fromCompiler
tonull | Compiler
. This means any TypeScript user who updates will get a compilation failure over it.Are types considered a part of the Webpack API that warrant breaking changes? Do you plan (or maybe already have) tests for types not breaking again without a major version update?
I haven't checked whether it was/is possible to get an actual
null
as a result of callingwebpack
. Could this happen before? Would you accept a type refinement PR (e.g. with overloads) that gives majority of users aCompiler
without anull
possibility?Beta Was this translation helpful? Give feedback.
All reactions