Fix leak in CommImplMPI::GroupByShm (#4665)

eisenhauer · web-flow · commit edc5541ff678 · 2025-10-15T14:09:41.000-04:00
diff --git a/source/adios2/helper/adiosCommMPI.cpp b/source/adios2/helper/adiosCommMPI.cpp
@@ -252,8 +252,8 @@ std::unique_ptr<CommImpl> CommImplMPI::GroupByShm(const std::string &hint) const
     MPI_Info info;
     MPI_Info_create(&info);
     CheckMPIReturn(MPI_Comm_split_type(m_MPIComm, MPI_COMM_TYPE_SHARED, 0, info, &nodeComm), hint);
-    return std::unique_ptr<CommImpl>(new CommImplMPI(nodeComm));
     MPI_Info_free(&info);
+    return std::unique_ptr<CommImpl>(new CommImplMPI(nodeComm));
 }
 
 int CommImplMPI::Rank() const

Original file line number	Diff line number	Diff line change
`@@ -252,8 +252,8 @@ std::unique_ptr<CommImpl> CommImplMPI::GroupByShm(const std::string &hint) const`
`252`	`252`	`MPI_Info info;`
`253`	`253`	`MPI_Info_create(&info);`
`254`	`254`	`CheckMPIReturn(MPI_Comm_split_type(m_MPIComm, MPI_COMM_TYPE_SHARED, 0, info, &nodeComm), hint);`
`255`		`- return std::unique_ptr<CommImpl>(new CommImplMPI(nodeComm));`
`256`	`255`	`MPI_Info_free(&info);`
	`256`	`+ return std::unique_ptr<CommImpl>(new CommImplMPI(nodeComm));`
`257`	`257`	`}`
`258`	`258`
`259`	`259`	`int CommImplMPI::Rank() const`