Skip to content

Tanh applied only to mask rather than to final result #5

Open
@baumgach

Description

@baumgach

We found another deviation to the original implementation. The tanh non-linearity is only applied to the mask output, rather than to the generated image, i.e. tanh(m(x)) rather than tanh(m(x)+x). The mistake happens on this line: https://github.com/orobix/Visual-Feature-Attribution-Using-Wasserstein-GANs-Pytorch/blob/master/src/train.py#L63

I know you don't have the capacities to fix this at the moment, and I also don't know if I will have the time. So I am mainly posting this issue to document the problem.

Best wishes,
Christian

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions