Merge pull request #1927 from laboro/ticket/OC-632_useless_flush_1_12

OC-632: "Maximum function nesting level of '300' reached" running oro…

Author: mkudelya

Diff for: src/OroCRM/Bundle/AnalyticsBundle/Resources/config/process.yml

@@ -23,7 +23,6 @@ definitions:
                     - '@create_entity':
                         class: JMS\JobQueueBundle\Entity\Job
                         attribute: $.syncJob
-                        flush: true
                         arguments:
                             - $.commandName
                             - [$.channelArguments]

Diff for: src/OroCRM/Bundle/CaseBundle/Resources/config/process.yml

@@ -69,7 +69,7 @@ definitions:
                             - '@create_entity':
                                 class: OroCRM\Bundle\CaseBundle\Entity\CaseEntity
                                 attribute: $.caseEntity
-                                flush: true
+                                flush: true # flush is required to allow activity handling later
                                 data:
                                     owner:          $.mailbox.processSettings.owner
                                     assignedTo:     $.mailbox.processSettings.assignTo

Diff for: src/OroCRM/Bundle/MagentoBundle/Resources/config/process.yml

@@ -297,7 +297,6 @@ definitions:
                     - '@create_entity':
                         class: JMS\JobQueueBundle\Entity\Job
                         attribute: $.syncJob
-                        flush: true
                         arguments:
                             - $.commandName
                             - [$.channelArguments]
@@ -341,7 +340,6 @@ definitions:
                     - '@create_entity':
                         class: JMS\JobQueueBundle\Entity\Job
                         attribute: $.syncJob
-                        flush: true
                         arguments:
                             - $.commandName
                             - [$.channelArguments]

Diff for: src/OroCRM/Bundle/SalesBundle/Resources/config/oro/workflow/b2b_flow_lead/transition_definitions.yml

@@ -162,7 +162,7 @@ workflows:
                     - '@create_entity': # create an opportunity
                         class: OroCRM\Bundle\SalesBundle\Entity\Opportunity
                         attribute: $.result.opportunity
-                        flush: true
+                        flush: true # flush is required to build redirect URL later
                         data:
                             name:        $opportunity_name
                             contact:     $lead.contact