fix(mock): makes resolveMockValue only return one factory import per ref-property (#3614)

* fix(mock): make resolveMockValue only return one factory import per ref-property

* test(mock): cleans up unnecessary properties and assertions, drops looping N times

---------

Co-authored-by: Nicolay <nicolay.mohebi@itverket.no>

Author: nicolactic

packages/mock/src/faker/index.test.ts

@@ -1,6 +1,7 @@
 import type {
   ClientMockBuilder,
   FakerMockOptions,
+  GeneratorImport,
   GeneratorOptions,
   GeneratorSchema,
   GeneratorVerbOptions,
@@ -18,6 +19,7 @@ import {
   generateFakerForSchemas,
   generateFakerImports,
 } from './index';
+import { resolveMockValue } from './resolvers';
 
 const mockVerbOptions = {
   operationId: 'getUser',
@@ -305,3 +307,55 @@ describe('generateFakerForSchemas strict mock types (#3525)', () => {
     );
   });
 });
+
+describe('resolveMockValue returns one factory import per ref-property (#3606)', () => {
+  // Delegation to a `get<X>Mock` factory requires output.schemas to be set and
+  // the $ref to point at a components schema.
+  const context = createTestContextSpec({
+    output: {
+      schemas: 'model',
+      mock: {
+        indexMockFiles: false,
+        generators: [{ type: OutputMockType.FAKER, schemas: true }],
+      },
+    },
+    spec: {
+      components: {
+        schemas: {
+          LeafDTO: { type: 'object', properties: { id: { type: 'string' } } },
+        },
+      },
+    },
+  });
+
+  const resolveLeafRef = (imports: GeneratorImport[]) =>
+    resolveMockValue({
+      schema: { $ref: '#/components/schemas/LeafDTO' },
+      operationId: 'getUser',
+      tags: [],
+      context,
+      imports,
+      existingReferencedProperties: [],
+      splitMockImplementations: [],
+    });
+
+  it('returns only its own factory import', () => {
+    // Shared imports array given to both calls. The first call can't reveal the
+    // bug since imports is empty.
+    const imports: GeneratorImport[] = [];
+
+    const first = resolveLeafRef(imports);
+    expect(first.imports).toHaveLength(1);
+    expect(first.imports[0]).toMatchObject({
+      name: 'getLeafDTOMock',
+      schemaFactory: true,
+    });
+
+    const second = resolveLeafRef(imports);
+    expect(second.imports).toHaveLength(1);
+    expect(second.imports[0]).toMatchObject({
+      name: 'getLeafDTOMock',
+      schemaFactory: true,
+    });
+  });
+});

packages/mock/src/faker/resolvers/value.ts

@@ -356,11 +356,12 @@ export function resolveMockValue({
 
     if (canDelegate) {
       const factoryName = `get${pascal(name)}Mock`;
-      imports.push({
+      const factoryImport: GeneratorImport = {
         name: factoryName,
         values: true,
         schemaFactory: true,
-      });
+      };
+
       // For object-like refs the historical inline output is `{ ...body }`
       // so the spread form keeps callers (combineSchemasMock, object
       // properties) working without other changes. For everything else
@@ -385,7 +386,7 @@ export function resolveMockValue({
           Boolean(newSchema.nullable),
           mockOptions?.nonNullable,
         ),
-        imports,
+        imports: [factoryImport],
         name: newSchema.name,
         type: getType(newSchema),
         nullWrapped: Boolean(newSchema.nullable) && !mockOptions?.nonNullable,