perf(core): avoid repeated schema name scans (#3843)

Author: jaydaVis04

packages/core/src/getters/object.test.ts

@@ -0,0 +1,117 @@
+import { describe, expect, it } from 'vitest';
+
+import { createTestContextSpec } from '../test-utils/context';
+import type { OpenApiSchemaObject } from '../types';
+import { getObject } from './object';
+
+describe('getObject', () => {
+  it('suffixes inline object property schema names that collide with component schemas', () => {
+    const context = createTestContextSpec({
+      spec: {
+        components: {
+          schemas: {
+            UserDetails: { type: 'object' },
+          },
+        },
+      },
+    });
+
+    const result = getObject({
+      item: {
+        type: 'object',
+        properties: {
+          details: {
+            type: 'object',
+            properties: {
+              name: { type: 'string' },
+            },
+          },
+        },
+      },
+      name: 'User',
+      context,
+      nullable: '',
+    });
+
+    expect(result.value).toContain('details?: UserDetailsProperty');
+    expect(result.schemas).toEqual(
+      expect.arrayContaining([
+        expect.objectContaining({ name: 'UserDetailsProperty' }),
+      ]),
+    );
+  });
+
+  it('uses the same PascalCase collision semantics for differently cased or separated schema names', () => {
+    const context = createTestContextSpec({
+      spec: {
+        components: {
+          schemas: {
+            'user-details': { type: 'object' },
+            user_details: { type: 'object' },
+          },
+        },
+      },
+    });
+
+    const result = getObject({
+      item: {
+        type: 'object',
+        properties: {
+          details: {
+            type: 'object',
+            properties: {
+              enabled: { type: 'boolean' },
+            },
+          },
+        },
+      } satisfies OpenApiSchemaObject,
+      name: 'User',
+      context,
+      nullable: '',
+    });
+
+    expect(result.value).toContain('details?: UserDetailsProperty');
+    expect(result.schemas).toEqual(
+      expect.arrayContaining([
+        expect.objectContaining({ name: 'UserDetailsProperty' }),
+      ]),
+    );
+  });
+
+  it('keeps inline object property schema names unchanged when component schemas do not collide', () => {
+    const context = createTestContextSpec({
+      spec: {
+        components: {
+          schemas: {
+            AccountDetails: { type: 'object' },
+          },
+        },
+      },
+    });
+
+    const result = getObject({
+      item: {
+        type: 'object',
+        properties: {
+          details: {
+            type: 'object',
+            properties: {
+              name: { type: 'string' },
+            },
+          },
+        },
+      },
+      name: 'User',
+      context,
+      nullable: '',
+    });
+
+    expect(result.value).toContain('details?: UserDetails');
+    expect(result.value).not.toContain('UserDetailsProperty');
+    expect(result.schemas).toEqual(
+      expect.arrayContaining([
+        expect.objectContaining({ name: 'UserDetails' }),
+      ]),
+    );
+  });
+});

packages/core/src/getters/object.ts

@@ -171,6 +171,16 @@ interface GetObjectOptions {
   formDataContext?: FormDataContext;
 }
 
+function getNormalizedComponentSchemaNames(context: ContextSpec): Set<string> {
+  context.normalizedComponentSchemaNames ??= new Set(
+    Object.keys(context.spec.components?.schemas ?? {}).map((schemaName) =>
+      pascal(schemaName),
+    ),
+  );
+
+  return context.normalizedComponentSchemaNames;
+}
+
 /**
  * Return the output type from an object
  *
@@ -398,11 +408,8 @@ export function getObject({
         );
       }
 
-      const allSpecSchemas = context.spec.components?.schemas ?? {};
-
-      const isNameAlreadyTaken = Object.keys(allSpecSchemas).some(
-        (schemaName) => pascal(schemaName) === propName,
-      );
+      const isNameAlreadyTaken =
+        getNormalizedComponentSchemaNames(context).has(propName);
 
       if (isNameAlreadyTaken) {
         propName = propName + 'Property';

packages/core/src/types.ts

@@ -1387,6 +1387,12 @@ export interface ContextSpec {
    * Populated by `getDynamicAnchorIndex` in `resolvers/ref.ts`.
    */
   dynamicAnchorIndex?: Map<string, DynamicAnchorIndexEntry>;
+  /**
+   * Lazily-built set of normalized component schema names, used while naming
+   * inline object-property schemas so component name collision checks do not
+   * rescan `components.schemas` for every property.
+   */
+  normalizedComponentSchemaNames?: Set<string>;
   /**
    * Tracks array-item mock factory names already emitted per output file scope.
    * Populated by `@orval/mock` when `arrayItems: true` so shared `$ref` item