fix(angular): keep httpResource type imports type-only

Author: haydenholligan

packages/angular/src/http-resource.test.ts

@@ -429,6 +429,40 @@ describe('angular httpResource generator', () => {
       expect(importNames).toContain('Pet');
       expect(importNames).not.toContain('Error');
     });
+
+    it('keeps zod array response imports type-only when parse is not generated', async () => {
+      const output = createOutput({
+        schemas: {
+          type: 'zod',
+          path: '/tmp/schemas',
+        } as NormalizedOutputOptions['schemas'],
+      });
+      const verbOption = createVerbOption({
+        response: baseResponse({
+          imports: [{ name: 'Pet' }],
+          definition: { success: 'Pet[]', errors: 'Error' },
+          types: {
+            success: [createSuccessType('Pet[]', 'application/json')],
+            errors: [],
+          },
+        }),
+      });
+
+      const result = await generateHttpResourceClient(
+        verbOption,
+        createGeneratorOptions({
+          route: '/api/pets',
+          context: createContextSpec(output),
+          override: output.override,
+          output: output.target,
+        }),
+        'angular',
+        output,
+      );
+
+      expect(result.imports).toContainEqual({ name: 'Pet' });
+      expect(result.imports).not.toContainEqual({ name: 'Pet', values: true });
+    });
   });
 
   // ─── Route registry fallback ──────────────────────────────────────

packages/angular/src/http-resource.ts

@@ -542,25 +542,86 @@ const getHttpResourceResponseImports = (
   });
 };
 
+const getParseSchemaName = (
+  response: {
+    readonly imports: readonly { name: string; isZodSchema?: boolean }[];
+    readonly definition: { readonly success?: string };
+  },
+  factory: HttpResourceFactoryName,
+  output: NormalizedOutputOptions,
+  responseTypeOverride?: string,
+): string | undefined => {
+  if (factory !== 'httpResource') return undefined;
+
+  // Explicit isZodSchema flag on imports (forward-compatible)
+  const zodSchema = response.imports.find((imp) => imp.isZodSchema);
+  if (zodSchema) return zodSchema.name;
+
+  // Check if runtime validation is disabled
+  if (!output.override.angular.runtimeValidation) return undefined;
+
+  // Auto-detect: when schemas.type === 'zod', use the response type as the schema name
+  if (!isZodSchemaOutput(output)) return undefined;
+
+  const responseType = responseTypeOverride ?? response.definition.success;
+  if (!responseType) return undefined;
+  if (isPrimitiveType(responseType)) return undefined;
+
+  // Verify a matching import exists (the response type name resolves to a zod schema)
+  const hasMatchingImport = response.imports.some(
+    (imp) => imp.name === responseType,
+  );
+  if (!hasMatchingImport) return undefined;
+
+  return responseType;
+};
+
+const getHttpResourceZodParsedImportNames = (
+  response: GeneratorVerbOptions['response'],
+  output: NormalizedOutputOptions,
+): Set<string> => {
+  const names = new Set<string>();
+
+  for (const successType of response.types.success) {
+    const schemaName = getParseSchemaName(
+      response,
+      getHttpResourceFactory(
+        response,
+        successType.contentType,
+        successType.value,
+      ),
+      output,
+      successType.value,
+    );
+
+    if (schemaName) {
+      names.add(schemaName);
+    }
+  }
+
+  return names;
+};
+
 const getHttpResourceVerbImports = (
   verbOptions: GeneratorVerbOptions,
   output: NormalizedOutputOptions,
 ): GeneratorImport[] => {
   const { response, body, queryParams, props, headers, params } = verbOptions;
-  const responseImports = isZodSchemaOutput(output)
-    ? [
-        ...getHttpResourceResponseImports(response).map((imp) => ({
-          ...imp,
-          values: true,
-        })),
-        ...getHttpResourceResponseImports(response)
-          .filter((imp) => !isPrimitiveType(imp.name))
-          .map((imp) => ({ name: getSchemaOutputTypeRef(imp.name) })),
-      ]
-    : getHttpResourceResponseImports(response);
+  const responseImports = getHttpResourceResponseImports(response);
+  const parsedZodImportNames = isZodSchemaOutput(output)
+    ? getHttpResourceZodParsedImportNames(response, output)
+    : new Set<string>();
+  const parsedZodImports = responseImports.filter((imp) =>
+    parsedZodImportNames.has(imp.name),
+  );
 
   return [
-    ...responseImports,
+    ...responseImports.map((imp) =>
+      parsedZodImportNames.has(imp.name) ? { ...imp, values: true } : imp,
+    ),
+    ...parsedZodImports
+      .filter((imp) => !isPrimitiveType(imp.name))
+      .map((imp) => ({ name: getSchemaOutputTypeRef(imp.name) })),
     ...body.imports,
     ...props.flatMap((prop) =>
       prop.type === GetterPropType.NAMED_PATH_PARAMS
@@ -583,29 +644,14 @@ const getParseExpression = (
   output: NormalizedOutputOptions,
   responseTypeOverride?: string,
 ): string | undefined => {
-  if (factory !== 'httpResource') return undefined;
-
-  // Explicit isZodSchema flag on imports (forward-compatible)
-  const zodSchema = response.imports.find((imp) => imp.isZodSchema);
-  if (zodSchema) return `${zodSchema.name}.parse`;
-
-  // Check if runtime validation is disabled
-  if (!output.override.angular.runtimeValidation) return undefined;
-
-  // Auto-detect: when schemas.type === 'zod', use the response type as the schema name
-  if (!isZodSchemaOutput(output)) return undefined;
-
-  const responseType = responseTypeOverride ?? response.definition.success;
-  if (!responseType) return undefined;
-  if (isPrimitiveType(responseType)) return undefined;
-
-  // Verify a matching import exists (the response type name resolves to a zod schema)
-  const hasMatchingImport = response.imports.some(
-    (imp) => imp.name === responseType,
+  const schemaName = getParseSchemaName(
+    response,
+    factory,
+    output,
+    responseTypeOverride,
   );
-  if (!hasMatchingImport) return undefined;
 
-  return `${responseType}.parse`;
+  return schemaName ? `${schemaName}.parse` : undefined;
 };
 
 /**

tests/__snapshots__/angular/http-resource-zod-disabled/endpoints.ts

@@ -31,15 +31,13 @@ import {
   Observable
 } from 'rxjs';
 
-import {
-  Pet,
-  PetWithTag,
-  Pets
-} from './model';
 import type {
   CreatePetsBody,
   CreatePetsParams,
-  ListPetsParams
+  ListPetsParams,
+  Pet,
+  PetWithTag,
+  Pets
 } from './model';
 
 import {

tests/__snapshots__/angular/http-resource-zod/endpoints.ts

@@ -31,15 +31,13 @@ import {
   Observable
 } from 'rxjs';
 
-import {
-  Pet,
-  PetWithTag,
-  Pets
-} from './model';
 import type {
   CreatePetsBody,
   CreatePetsParams,
-  ListPetsParams
+  ListPetsParams,
+  Pet,
+  PetWithTag,
+  Pets
 } from './model';
 
 import {