fix: otlp sampling rate default

GitOrigin-RevId: 8a01bded7d8eca0ac3a81de793286144aab16426

Author: nipsufn

oryx/configx/provider.go

@@ -412,6 +412,17 @@ func (p *Provider) Float64F(key string, fallback float64) (val float64) {
 	return p.Float64(key)
 }
 
+func (p *Provider) Float64PtrF(key string, fallback float64) (val *float64) {
+	p.l.RLock()
+	defer p.l.RUnlock()
+
+	if !p.Koanf.Exists(key) {
+		return &fallback
+	}
+	out := p.Float64(key)
+	return &out
+}
+
 func (p *Provider) DurationF(key string, fallback time.Duration) (val time.Duration) {
 	p.l.RLock()
 	defer p.l.RUnlock()
@@ -471,21 +482,21 @@ func (p *Provider) TracingConfig(serviceName string) *otelx.Config {
 			Jaeger: otelx.JaegerConfig{
 				Sampling: otelx.JaegerSampling{
 					ServerURL:    p.String("tracing.providers.jaeger.sampling.server_url"),
-					TraceIdRatio: p.Float64F("tracing.providers.jaeger.sampling.trace_id_ratio", 1),
+					TraceIdRatio: p.Float64PtrF("tracing.providers.jaeger.sampling.trace_id_ratio", 1.0),
 				},
 				LocalAgentAddress: p.String("tracing.providers.jaeger.local_agent_address"),
 			},
 			Zipkin: otelx.ZipkinConfig{
 				ServerURL: p.String("tracing.providers.zipkin.server_url"),
 				Sampling: otelx.ZipkinSampling{
-					SamplingRatio: p.Float64("tracing.providers.zipkin.sampling.sampling_ratio"),
+					SamplingRatio: p.Float64PtrF("tracing.providers.zipkin.sampling.sampling_ratio",0.0),
 				},
 			},
 			OTLP: otelx.OTLPConfig{
 				ServerURL: p.String("tracing.providers.otlp.server_url"),
 				Insecure:  p.Bool("tracing.providers.otlp.insecure"),
 				Sampling: otelx.OTLPSampling{
-					SamplingRatio: p.Float64F("tracing.providers.otlp.sampling.sampling_ratio", 1),
+					SamplingRatio: p.Float64PtrF("tracing.providers.otlp.sampling.sampling_ratio", 1.0),
 				},
 				AuthorizationHeader: p.String("tracing.providers.otlp.authorization_header"),
 			},

oryx/go.mod

@@ -209,6 +209,7 @@ require (
 	google.golang.org/genproto/googleapis/rpc v0.0.0-20250313205543-e70fdf4c4cb4 // indirect
 	gopkg.in/yaml.v2 v2.4.0 // indirect
 	gopkg.in/yaml.v3 v3.0.1 // indirect
+	k8s.io/utils v0.0.0-20250604170112-4c0f3b243397
 	sigs.k8s.io/yaml v1.4.0 // indirect
 )
 

oryx/go.sum

@@ -724,5 +724,7 @@ gopkg.in/yaml.v3 v3.0.1/go.mod h1:K4uyk7z7BCEPqu6E+C64Yfv1cQ7kz7rIZviUmN+EgEM=
 gotest.tools/v3 v3.5.1 h1:EENdUnS3pdur5nybKYIh2Vfgc8IUNBjxDPSjtiJcOzU=
 gotest.tools/v3 v3.5.1/go.mod h1:isy3WKz7GK6uNw/sbHzfKBLvlvXwUyV06n6brMxxopU=
 honnef.co/go/tools v0.0.1-2019.2.3/go.mod h1:a3bituU0lyd329TUQxRnasdCoJDkEUEAqEt0JzvZhAg=
+k8s.io/utils v0.0.0-20250604170112-4c0f3b243397 h1:hwvWFiBzdWw1FhfY1FooPn3kzWuJ8tmbZBHi4zVsl1Y=
+k8s.io/utils v0.0.0-20250604170112-4c0f3b243397/go.mod h1:OLgZIPagt7ERELqWJFomSt595RzquPNLL48iOWgYOg0=
 sigs.k8s.io/yaml v1.4.0 h1:Mk1wCc2gy/F0THH0TAp1QYyJNzRm2KCLy3o5ASXVI5E=
 sigs.k8s.io/yaml v1.4.0/go.mod h1:Ejl7/uTz7PSA4eKMyQCUTnhZYNmLIl+5c2lQPGR2BPY=

oryx/otelx/config.go

@@ -27,16 +27,16 @@ type OTLPConfig struct {
 }
 
 type JaegerSampling struct {
-	ServerURL    string  `json:"server_url"`
-	TraceIdRatio float64 `json:"trace_id_ratio"`
+	ServerURL    string   `json:"server_url"`
+	TraceIdRatio *float64 `json:"trace_id_ratio"`
 }
 
 type ZipkinSampling struct {
-	SamplingRatio float64 `json:"sampling_ratio"`
+	SamplingRatio *float64 `json:"sampling_ratio"`
 }
 
 type OTLPSampling struct {
-	SamplingRatio float64 `json:"sampling_ratio"`
+	SamplingRatio *float64 `json:"sampling_ratio"`
 }
 
 type ProvidersConfig struct {
@@ -61,6 +61,7 @@ const ConfigSchemaID = "ory://tracing-config"
 // The interface is specified instead of `jsonschema.Compiler` to allow the use of any jsonschema library fork or version.
 func AddConfigSchema(c interface {
 	AddResource(url string, r io.Reader) error
-}) error {
+},
+) error {
 	return c.AddResource(ConfigSchemaID, bytes.NewBufferString(ConfigSchema))
 }

oryx/otelx/jaeger.go

@@ -51,10 +51,13 @@ func SetupJaeger(t *Tracer, tracerName string, c *Config) (trace.Tracer, error)
 	}
 
 	samplingServerURL := c.Providers.Jaeger.Sampling.ServerURL
-	traceIdRatio := c.Providers.Jaeger.Sampling.TraceIdRatio
-
-	sampler := sdktrace.TraceIDRatioBased(traceIdRatio)
 
+	var sampler sdktrace.Sampler
+	if c.Providers.Jaeger.Sampling.TraceIdRatio != nil {
+		sampler = sdktrace.TraceIDRatioBased(*c.Providers.Jaeger.Sampling.TraceIdRatio)
+	} else {
+		sampler = sdktrace.TraceIDRatioBased(1)
+	}
 	if samplingServerURL != "" {
 		sampler = jaegerremote.New(
 			"jaegerremote",

oryx/otelx/otlp.go

@@ -41,17 +41,18 @@ func SetupOTLP(t *Tracer, tracerName string, c *Config) (trace.Tracer, error) {
 	if err != nil {
 		return nil, err
 	}
-
+	var sampler sdktrace.Sampler
+	if c.Providers.OTLP.Sampling.SamplingRatio != nil {
+		sampler = sdktrace.ParentBased(sdktrace.TraceIDRatioBased(*c.Providers.OTLP.Sampling.SamplingRatio))
+	}
 	tpOpts := []sdktrace.TracerProviderOption{
 		sdktrace.WithBatcher(exp),
 		sdktrace.WithResource(resource.NewWithAttributes(
 			semconv.SchemaURL,
 			semconv.ServiceName(c.ServiceName),
 			semconv.DeploymentEnvironmentName(c.DeploymentEnvironment),
 		)),
-		sdktrace.WithSampler(sdktrace.ParentBased(sdktrace.TraceIDRatioBased(
-			c.Providers.OTLP.Sampling.SamplingRatio,
-		))),
+		sdktrace.WithSampler(sampler),
 	}
 
 	tp := sdktrace.NewTracerProvider(tpOpts...)

oryx/otelx/zipkin.go

@@ -18,16 +18,18 @@ func SetupZipkin(t *Tracer, tracerName string, c *Config) (trace.Tracer, error)
 		return nil, err
 	}
 
+	var sampler sdktrace.Sampler
+	if c.Providers.Zipkin.Sampling.SamplingRatio != nil {
+		sampler = sdktrace.ParentBased(sdktrace.TraceIDRatioBased(*c.Providers.Zipkin.Sampling.SamplingRatio))
+	}
 	tpOpts := []sdktrace.TracerProviderOption{
 		sdktrace.WithBatcher(exp),
 		sdktrace.WithResource(resource.NewWithAttributes(
 			semconv.SchemaURL,
 			semconv.ServiceName(c.ServiceName),
 			semconv.DeploymentEnvironmentName(c.DeploymentEnvironment),
 		)),
-		sdktrace.WithSampler(sdktrace.ParentBased(sdktrace.TraceIDRatioBased(
-			c.Providers.Zipkin.Sampling.SamplingRatio,
-		))),
+		sdktrace.WithSampler(sampler),
 	}
 
 	tp := sdktrace.NewTracerProvider(tpOpts...)