added linting and formatting

Author: KT-Doan

.golangci.yml

@@ -44,15 +44,8 @@ linters:
 
     gocritic:
       disabled-checks:
-        # These are too noisy for Terraform providers
         - ifElseChain        # Sometimes clearer than switch
 
-    gosec:
-      excludes:
-        - G101 # Hardcoded credentials (false positives on test constants)
-        - G104 # Unhandled errors (too noisy for terraform providers)
-        - G304 # File path from variable (needed for terraform)
-
     misspell:
       locale: US
 
@@ -61,20 +54,17 @@ linters:
       - std-error-handling
       - common-false-positives
     rules:
-      # Exclude some linters from running on test files
+      # Test files have repetitive patterns and don't need strict error handling
       - path: _test\.go
         linters:
           - dupl
-          - gosec
           - goconst
           - errorlint
 
-      # Terraform provider resources often have similar structure
       - path: internal/resources/
         linters:
           - dupl
 
-      # Terraform provider datasources often have similar structure
       - path: internal/datasources/
         linters:
           - dupl

internal/acctest/acctest.go

@@ -71,10 +71,10 @@ func AccPreCheck(t *testing.T) {
 	}
 
 	// Set environment variables for the provider to use
-	os.Setenv("ORY_PROJECT_ID", project.ID)
-	os.Setenv("ORY_PROJECT_SLUG", project.Slug)
-	os.Setenv("ORY_PROJECT_API_KEY", project.APIKey)
-	os.Setenv("ORY_PROJECT_ENVIRONMENT", project.Environment)
+	_ = os.Setenv("ORY_PROJECT_ID", project.ID)
+	_ = os.Setenv("ORY_PROJECT_SLUG", project.Slug)
+	_ = os.Setenv("ORY_PROJECT_API_KEY", project.APIKey)
+	_ = os.Setenv("ORY_PROJECT_ENVIRONMENT", project.Environment)
 }
 
 // GetTestProject returns the shared test project, loading from env vars or creating if necessary.

internal/provider/provider_test.go

@@ -76,8 +76,8 @@ func TestResolveString(t *testing.T) {
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
 			if tt.envValue != "" {
-				os.Setenv(tt.envVar, tt.envValue)
-				defer os.Unsetenv(tt.envVar)
+				_ = os.Setenv(tt.envVar, tt.envValue)
+				defer func() { _ = os.Unsetenv(tt.envVar) }()
 			}
 
 			result := resolveString(tt.tfValue, tt.envVar)
@@ -142,8 +142,8 @@ func TestResolveStringDefault(t *testing.T) {
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
 			if tt.envValue != "" {
-				os.Setenv(tt.envVar, tt.envValue)
-				defer os.Unsetenv(tt.envVar)
+				_ = os.Setenv(tt.envVar, tt.envValue)
+				defer func() { _ = os.Unsetenv(tt.envVar) }()
 			}
 
 			result := resolveStringDefault(tt.tfValue, tt.envVar, tt.defaultValue)

internal/testutil/testutil.go

@@ -25,10 +25,10 @@ const (
 // Test API key constants - fake keys for unit tests
 const (
 	// TestWorkspaceAPIKey is a fake workspace API key for tests.
-	TestWorkspaceAPIKey = "ory_wak_test"
+	TestWorkspaceAPIKey = "ory_wak_test" //nolint:gosec // G101 false positive - this is a fake test constant
 
 	// TestProjectAPIKey is a fake project API key for tests.
-	TestProjectAPIKey = "ory_pat_test"
+	TestProjectAPIKey = "ory_pat_test" //nolint:gosec // G101 false positive - this is a fake test constant
 
 	// TestProjectSlug is a test project slug.
 	TestProjectSlug = "test-project-slug"