Skip to content

Commit 052c4bd

Browse files
authored
Merge pull request #290 from d3flex/feat/mm
fix: ensure br1 for cleanup and prevent timeout from get_logs
2 parents 1025acb + 932f383 commit 052c4bd

3 files changed

Lines changed: 4 additions & 3 deletions

File tree

lib/openQAcoretest.pm

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,8 @@ sub post_fail_hook ($self) {
77
switch_to_root_console;
88
send_key 'ctrl-c'; # Stop current command, if any
99
# we can't upload logs if the multimachine OVS bridge in the SUT has the same IP as the openQA-worker host
10-
script_run 'ip a del 10.0.2.2/15 dev br1'; # This may fail in case this IP is not actually set on the bridge
10+
# This may fail in case this IP is not actually set on the bridge
11+
script_run 'ip link show br1 && ip a del 10.0.2.2/15 dev br1';
1112
if (get_var('OPENQA_FROM_GIT')) {
1213
assert_script_run 'cd /root/openQA';
1314
enter_cmd 'script/openqa-cli api jobs';

lib/utils.pm

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ use File::Basename qw(basename);
88
our @EXPORT = qw(get_log install_packages clear_root_console switch_to_root_console switch_to_x11 wait_for_desktop login ensure_unlocked_desktop wait_for_container_log prepare_firefox_autoconfig disable_packagekit);
99

1010
sub get_log ($cmd, $name) {
11-
my $ret = script_run "$cmd | tee $name";
11+
my $ret = script_run "$cmd | tee $name", timeout => 300;
1212
upload_logs($name) unless $ret;
1313
}
1414

tests/osautoinst/test_running.pm

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ sub run ($self) {
1212
echo \$r | grep -q "$success"'}, timeout => 1830;
1313
if (get_var('FULL_MM_TEST')) {
1414
# we can't upload logs if the multimachine OVS bridge in the SUT has the same IP as the openQA-worker host
15-
script_run 'ip a del 10.0.2.2/15 dev br1'; # This may fail in case this IP is not actually set on the bridge
15+
script_run 'ip link show br1 && ip a del 10.0.2.2/15 dev br1';
1616
$self->upload_openqa_logs;
1717
}
1818
save_screenshot;

0 commit comments

Comments
 (0)