Deallocate with delete[] if new[] has been used for allocation

Found by valgrind.

Author: osander1

ADOL-C/src/tape_handling.cpp

@@ -604,23 +604,23 @@ void cleanUp() {
         remove((*tiIter)->pTapeInfos.tay_fileName);
       }
       if ((*tiIter)->opBuffer != NULL) {
-        free((*tiIter)->opBuffer);
+        delete[] ((*tiIter)->opBuffer);
         (*tiIter)->opBuffer = NULL;
       }
       if ((*tiIter)->valBuffer != NULL) {
-        free((*tiIter)->valBuffer);
+        delete[] ((*tiIter)->valBuffer);
         (*tiIter)->valBuffer = NULL;
       }
       if ((*tiIter)->locBuffer != NULL) {
-        free((*tiIter)->locBuffer);
+        delete[] ((*tiIter)->locBuffer);
         (*tiIter)->locBuffer = NULL;
       }
       if ((*tiIter)->signature != NULL) {
         free((*tiIter)->signature);
         (*tiIter)->signature = NULL;
       }
       if ((*tiIter)->tayBuffer != NULL) {
-        free((*tiIter)->tayBuffer);
+        delete[] ((*tiIter)->tayBuffer);
         (*tiIter)->tayBuffer = NULL;
       }
 
@@ -659,19 +659,19 @@ void cleanUp() {
           remove((*tiIter)->pTapeInfos.val_fileName);
       }
       if ((*tiIter)->pTapeInfos.op_fileName != NULL) {
-        free((*tiIter)->pTapeInfos.op_fileName);
+        delete[] ((*tiIter)->pTapeInfos.op_fileName);
         (*tiIter)->pTapeInfos.op_fileName = NULL;
       }
       if ((*tiIter)->pTapeInfos.val_fileName != NULL) {
-        free((*tiIter)->pTapeInfos.val_fileName);
+        delete[] ((*tiIter)->pTapeInfos.val_fileName);
         (*tiIter)->pTapeInfos.val_fileName = NULL;
       }
       if ((*tiIter)->pTapeInfos.loc_fileName != NULL) {
-        free((*tiIter)->pTapeInfos.loc_fileName);
+        delete[] ((*tiIter)->pTapeInfos.loc_fileName);
         (*tiIter)->pTapeInfos.loc_fileName = NULL;
       }
       if ((*tiIter)->pTapeInfos.tay_fileName != NULL) {
-        free((*tiIter)->pTapeInfos.tay_fileName);
+        delete[] ((*tiIter)->pTapeInfos.tay_fileName);
         (*tiIter)->pTapeInfos.tay_fileName = NULL;
       }
 
@@ -1163,7 +1163,7 @@ PersistantTapeInfos::~PersistantTapeInfos() {
     forodec_nax = 0;
   }
   if (paramstore != NULL) {
-    free(paramstore);
+    delete[] paramstore;
     paramstore = NULL;
   }
 }

ADOL-C/src/taping.cpp

@@ -362,7 +362,7 @@ void clearTapeBaseNames() {
   int i;
   for (i = 0; i < 4; i++) {
     if (tapeBaseNames[i]) {
-      delete tapeBaseNames[i];
+      delete[] tapeBaseNames[i];
       tapeBaseNames[i] = nullptr;
     }
   }
@@ -1153,7 +1153,7 @@ static void save_params() {
 
   ADOLC_CURRENT_TAPE_INFOS.stats[NUM_PARAM] = ADOLC_GLOBAL_TAPE_VARS.numparam;
   if (ADOLC_CURRENT_TAPE_INFOS.pTapeInfos.paramstore != nullptr)
-    delete ADOLC_CURRENT_TAPE_INFOS.pTapeInfos.paramstore;
+    delete[] ADOLC_CURRENT_TAPE_INFOS.pTapeInfos.paramstore;
 
   ADOLC_CURRENT_TAPE_INFOS.pTapeInfos.paramstore =
       new double[ADOLC_CURRENT_TAPE_INFOS.stats[NUM_PARAM]];