Rework Koji/CloudAPI configuration in composer

[thozza]

Describe the bug
Currently, the Koji and CloudAPI configurations are mixed in a single KojiAPIConfig structure, mainly because both APIs share the same listener.

osbuild-composer/cmd/osbuild-composer/config.go

Lines 19 to 28 in 510bd1d

	type KojiAPIConfig struct {
	AllowedDomains []string `toml:"allowed_domains"`
	CA string `toml:"ca"`
	EnableTLS bool `toml:"enable_tls"`
	EnableMTLS bool `toml:"enable_mtls"`
	EnableJWT bool `toml:"enable_jwt"`
	JWTKeysURL string `toml:"jwt_keys_url"`
	JWTKeysCA string `toml:"jwt_ca_file"`
	JWTACLFile string `toml:"jwt_acl_file"`
	}

This is getting a bit confusing, because with PR #1841, the Koji API configuration will contain AWS Bucket value, which is not at all relevant for the Koji API.

Expected behavior
We should consider our options and rework the configuration in some way, e.g:

1. Split Koji and Cloud API configurations, probably also the listeners that they use.
2. Rename the Koji API configuration to something common, such as "Composer API".

[teg]

Thanks for capturing this, totally agreed. Of the two suggestions, I would favour option 2 under the assumption that eventually the APIs themselves would become one (by generalising the composer one so that it also can support koji). They were originally created separately (by me, or on my suggestion) just because I couldn't figure out at the time how to elegantly create one API that generalised the two things we wanted. But now that we have smarter people around...

[github-actions]

This issue is stale because it had no activity for the past 365 days. Remove the "Stale" label or add a comment, otherwise this issue will be closed in 30 days.