Skip to content

Enums in json mismatch #8

@sofyalaski

Description

@sofyalaski

I was looking at the enum values in the schema and realised there was a mismatch with PDBx values:

  1. "Sample.Molecule.Class" in JSON has the following enum values: ["Antibiotic", "Carbohydrate", "Chimera","None of these"]. According to conversions table, this value in mmCIF is called "_em_entity_assembly.type", which has different enums: ["CELL", "COMPLEX", "ORGANELLE OR CELLULAR COMPONENT", "RIBOSOME", "TISSUE", "VIRUS"]. I don't think they correspond, so maybe this property in JSON is called something else in mmCIF or not present at all?
  2. Author.Organization.Type_org values agree on what mmCIF contains, only they use all lowercase. This is more of a remark to myself
  3. mmCIF has more enum'ed properties in their dictionary and I wanted to ensure we support that. For instance, with the Grid type, I feel we really should enforce some enum value. As I remember Yves wanted to implement that as a drop-down menu when filling in sample information anyway. As of now if something like "quantifoil" is a value of that field, it is still written into the mmCIF as is. But it will not be taken over by EMDB/PDB.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions