fix: bump Hecke version

- purge Hecke.Order, Hecke.EquationOrder and Hecke.MaximalOrder

Author: thofma

Project.toml

@@ -37,7 +37,7 @@ Compat = "4.13.0"
 Distributed = "1.6"
 GAP = "0.13.1"
 GAP_lib_jll = "~400.1400.4" # remove again once GAP.jl requires this version
-Hecke = "= 0.35.15"
+Hecke = "0.35.17"
 JSON = "^0.20, ^0.21"
 JSON3 = "1.13.2"
 LazyArtifacts = "1.6"

experimental/DoubleAndHyperComplexes/src/Morphisms/strand_functionality.jl

@@ -63,7 +63,7 @@ end
 function all_exponents(W::MPolyDecRing, d::FinGenAbGroupElem)
   D = W.D
   is_free(D) || error("Grading group must be free")
-  h = hom(free_abelian_group(ngens(W)), W.d)
+  h = hom(free_abelian_group(ngens(W)), D, W.d)
   fl, p = has_preimage_with_preimage(h, d)
   R = base_ring(W)
   B = Vector{Int}[]

experimental/QuadFormAndIsom/src/embeddings.jl

@@ -27,15 +27,15 @@ function _sum_with_embeddings_orthogonal_groups(A::TorQuadModule, B::TorQuadModu
   geneOAinOD = elem_type(OD)[]
   for f in gens(OA)
     imgf = data.(union!(AinD.(f.(gens(A))), gensDB))
-    fab = hom(gene, imgf)
+    fab = hom(abelian_group(D), abelian_group(D), gene, imgf)
     fD = OD(hom(D, D, matrix(fab)); check=false)
     push!(geneOAinOD, fD)
   end
 
   geneOBinOD = elem_type(OD)[]
   for f in gens(OB)
     imgf = data.(union(gensDA, BinD.(f.(gens(B)))))
-    fab = hom(gene, imgf)
+    fab = hom(abelian_group(D), abelian_group(D), gene, imgf)
     fD = OD(hom(D, D, matrix(fab)); check=false)
     push!(geneOBinOD, fD)
   end

src/Groups/abelian_aut.jl

@@ -264,7 +264,7 @@ function embedding_orthogonal_group(i::TorQuadModuleMap)
   geneOAinOD = elem_type(OD)[]
   for f in gens(OA)
     imgf = data.(union(i.(f.(gens(A))), j.(gens(B))))
-    fab = hom(gene, imgf)
+    fab = hom(abelian_group(D), abelian_group(D), gene, imgf)
     fD = OD(hom(D, D, fab.map))
     push!(geneOAinOD, fD)
   end

src/Groups/homomorphisms.jl

@@ -153,9 +153,9 @@ function hom(G::GAPGroup, A::FinGenAbGroup, gensG::Vector, imgs::Vector{FinGenAb
 
   # map B to A as prescribed
   if length(gensG) == 0
-    map2 = hom([zero(B)], [zero(A)], check = check)
+    map2 = hom(B, A, [zero(B)], [zero(A)], check = check)
   else
-    map2 = hom([iso(map1(x)) for x in gensG], imgs, check = check)
+    map2 = hom(B, A, [iso(map1(x)) for x in gensG], imgs, check = check)
   end
 
   # create the composition

src/Groups/matrices/iso_nf_fq.jl

@@ -182,7 +182,7 @@ function test_modulus(matrices::Vector{T}, p::Int) where T <: MatrixElem{AbsSimp
    if p == 2
       return false, GF(p, cached = false), matrices_Fq, Hecke.NfOrdToFqMor()
    end
-   O = EquationOrder(K)
+   O = equation_order(K)
    if mod(discriminant(O), p) == 0
       return false, GF(p, cached = false), matrices_Fq, Hecke.NfOrdToFqMor()
    end

src/Rings/NumberField.jl

@@ -739,12 +739,12 @@ function Hecke.any_order(K::NfNSGen)
     @assert isone(denominator(b.f))
   end
 
-  O = Order(K, B)
+  O = order(K, B)
 
   return O
 end
 
-function Hecke.MaximalOrder(K::NfNSGen)
+function Hecke.maximal_order(K::NfNSGen)
   E = any_order(K)
   return Hecke._maximal_order_round_four(E)
 end

src/Rings/mpoly-graded.jl

@@ -1430,7 +1430,7 @@ function monomial_basis(W::MPolyDecRing, d::FinGenAbGroupElem)
   @req coefficient_ring(W) isa AbstractAlgebra.Field "The coefficient ring must be a field"
   D = W.D
   is_free(D) || error("Grading group must be free")
-  h = hom(free_abelian_group(ngens(W)), W.d)
+  h = hom(free_abelian_group(ngens(W)), D, W.d)
   fl, p = has_preimage_with_preimage(h, d)
   R = base_ring(W)
   B = elem_type(W)[]

test/NumberTheory/nmbthy.jl

@@ -60,7 +60,7 @@ end
   k, a = wildanger_field(3, 13)
   zk = maximal_order(k)
   b = zk(8*a^2 - 24*a - 1)
-  o = Order(k, 8 .* basis(zk))
+  o = order(k, 8 .* basis(zk))
   @test length(norm_equation(zk, norm(b))) == 4
   @test length(norm_equation(o, norm(b))) == 3