Skip to content

Unify residue_ring vs. quo #4412

Open
Open
@joschmitt

Description

@joschmitt

We have residue_ring and we have quo (and residue_field?) and they don't always do the same.
A real issue is the behaviour exposed in #4410 that residue_ring always (silently) assumes that the ring is euclidean. At least for multivariate polynomial rings, we can do better here by returning a proper multivariate quotient ring (this only works in OSCAR and not in AbstractAlgebra of course).
I'm aware that part of the problem is that we can't easily test whether a ring is euclidean, but at least we could clean up the names. Or is there some distinction that I don't see?

To quote @JohnAAbbott in #4410:

In any case, it is not good that residue_ring returns a EuclideanRingResidueRing when the result clearly is not -- it should either produce an error or give a correct result. I did not see anything in the documentation about restrictions on arguments for residue_ring.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions