-
Notifications
You must be signed in to change notification settings - Fork 166
Exterior power streamlining #5702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Exterior power streamlining #5702
Conversation
This reverts commit 59c6e2d.
|
I am neither in favor of nor objecting to this PR. My contribution to this PR is purely to keep the LieAlgebraModules consistent with FreeMod. |
|
On Wed, Jan 14, 2026 at 07:16:45AM -0800, Lars Göttgens wrote:
lgoettgens left a comment (oscar-system/Oscar.jl#5702)
I am neither in favor of nor objecting to this PR. My contribution to this PR is purely to keep the LieAlgebraModules consistent with FreeMod.
I also introduced deprecations for changes in the experimental "LieAlgebras", since I have personal code outside of Oscar, that uses these functions, which I would like not to break.
I know this .... very well...
Fun question:
exterior_power(hom): how does this interact with caching of structures?
Using tensor_product(hom, hom) has the same problem: it need to create
the tensor_products of the domains/ codomains...
I agree with the maths, but what about the cached structures?
… --
Reply to this email directly or view it on GitHub:
#5702 (comment)
You are receiving this because you are subscribed to this thread.
Message ID: ***@***.***>
|
For the modules the exterior powers are usually cached in the original module; unless they are created with Either way, the user may specify their own domain and codomain to be used for the result. In that case, they need to be compatible with the provided map, of course. |
|
@lgoettgens : One test in |
This removes
induced_map_on_exterior_powerand replaces it byexterior_power. Taking exterior powers is a functor, so it should be applicable to maps directly.Another family of methods which are now deprecated is
hom(::Obj, ::Obj, ::Morphism)which checks whether the first two arguments are exterior powers of the domain and codomain of the morphism, respectively, and then computes the induced map. Introducing this was probably never a clever idea and should not have happend imho.