Skip to content

Reduce number of unnecessary roundtrips to Glance #661

@mbuechse

Description

@mbuechse

There are many unnecessary roundtrips in manage.py:

  • Each time an image is uploaded, the whole list of images is retrieved anew, instead of just adding the newly uploaded image to the list.
  • For the subsequent call of set_properties, the whole list of images is again retrieved, when the actual image object could be passed to the function instead of just the name. (Mind you that this is the only call to set_properties ever, so it could readily be changed!)
  • For each of the potential adjustments of the metadata (min disk, min ram, os hidden, as well as each and every property that is missing or has the wrong value), a dedicated call to update_image is performed, when the changes could (easily!) be aggregated and the image updated only once.

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions