Do not create flavors during netbox/ironic sync (#1312)

Nova is not used for baremetal provisioning. Therefore flavor creation
for baremetal nodes is not required.

Signed-off-by: Jan Horstmann <[email protected]>

Author: janhorstmann

osism/tasks/conductor.py

@@ -198,11 +198,6 @@ def deep_compare(a, b, updates):
                 logger.info(
                     f"Cleaning up baremetal node not found in netbox: {node['Name']}"
                 )
-                flavor_name = "osism-" + node["Name"]
-                flavor = openstack.compute_flavor_get(flavor_name)
-                if flavor:
-                    logger.info(f"Deleting flavor {flavor_name}")
-                    openstack.compute_flavor_delete(flavor)
                 for port in openstack.baremetal_port_list(
                     details=False, attributes=dict(node_uuid=node["UUID"])
                 ):
@@ -271,19 +266,6 @@ def deep_compare(a, b, updates):
             for interface in node_interfaces
             if interface.enabled and not interface.mgmt_only and interface.mac_address
         ]
-        flavor_attributes = {
-            "ram": 1,
-            "disk": 0,
-            "vcpus": 1,
-            "is_public": False,
-            "extra_specs": {
-                "resources:CUSTOM_"
-                + device.name.upper().replace("-", "_").replace(".", "_"): "1",
-                "resources:VCPU": "0",
-                "resources:MEMORY_MB": "0",
-                "resources:DISK_GB": "0",
-            },
-        }
 
         lock = Redlock(
             key=f"lock_osism_tasks_conductor_sync_netbox_with_ironic-{device.name}",
@@ -413,48 +395,6 @@ def deep_compare(a, b, updates):
                     logger.info(
                         f"Validation of management interface failed for baremetal node for {device.name}\nReason: {node_validation['management'].reason}"
                     )
-
-                flavor_name = "osism-" + device.name
-                flavor = openstack.compute_flavor_get(flavor_name)
-                if not flavor:
-                    logger.info(f"Creating flavor for {flavor_name}")
-                    flavor = openstack.compute_flavor_create(
-                        flavor_name, flavor_attributes
-                    )
-                else:
-                    flavor_updates = {}
-                    deep_compare(flavor_attributes, flavor, flavor_updates)
-                    flavor_updates_extra_specs = flavor_updates.pop("extra_specs", None)
-                    if flavor_updates:
-                        logger.info(
-                            f"Updating flavor for {device.name} with {flavor_updates}"
-                        )
-                        openstack.compute_flavor_delete(flavor)
-                        flavor = openstack.compute_flavor_create(
-                            flavor_name, flavor_attributes
-                        )
-                    elif flavor_updates_extra_specs:
-                        logger.info(
-                            f"Updating flavor extra_specs for {device.name} with {flavor_updates_extra_specs}"
-                        )
-                        openstack.compute_flavor_update_extra_specs(
-                            flavor, flavor_updates_extra_specs
-                        )
-                        flavor = openstack.compute_flavor_get(flavor_name)
-                    for extra_specs_key in flavor["extra_specs"].keys():
-                        if (
-                            extra_specs_key
-                            not in flavor_attributes["extra_specs"].keys()
-                        ):
-                            logger.info(
-                                f"Deleting flavor extra_specs property {extra_specs_key} for {device.name}"
-                            )
-                            flavor = (
-                                openstack.compute_flavor_delete_extra_specs_property(
-                                    flavor, extra_specs_key
-                                )
-                            )
-
             except Exception as exc:
                 logger.info(
                     f"Could not fully synchronize device {device.name} with ironic: {exc}"

osism/tasks/openstack.py

@@ -136,47 +136,6 @@ def baremetal_port_delete(self, port_or_id):
     return result
 
 
-@app.task(bind=True, name="osism.tasks.openstack.compute_flavor_get")
-def compute_flavor_get(self, name_or_id):
-    conn = utils.get_openstack_connection()
-    result = conn.compute.find_flavor(
-        name_or_id, ignore_missing=True, get_extra_specs=True
-    )
-    return result
-
-
-@app.task(bind=True, name="osism.tasks.openstack.compute_flavor_create")
-def compute_flavor_create(self, name, attributes=None):
-    if attributes is None:
-        attributes = {}
-    attributes.update({"name": name})
-    extra_specs = attributes.pop("extra_specs", None)
-    conn = utils.get_openstack_connection()
-    flavor = conn.compute.create_flavor(**attributes)
-    if extra_specs:
-        flavor = conn.compute.create_flavor_extra_specs(flavor, extra_specs)
-    return flavor
-
-
-@app.task(bind=True, name="osism.tasks.openstack.compute_flavor_delete")
-def compute_flavor_delete(self, flavor):
-    conn = utils.get_openstack_connection()
-    conn.compute.delete_flavor(flavor, ignore_missing=True)
-
-
-@app.task(bind=True, name="osism.tasks.openstack.compute_flavor_update_extra_specs")
-def compute_flavor_update_extra_specs(self, flavor, extra_specs={}):
-    conn = utils.get_openstack_connection()
-    for key, value in extra_specs.items():
-        conn.compute.update_flavor_extra_specs_property(flavor, key, value)
-
-
-@app.task(bind=True, name="osism.tasks.openstack.compute_flavor_delete_extra_specs")
-def compute_flavor_delete_extra_specs_property(self, flavor, prop):
-    conn = utils.get_openstack_connection()
-    conn.compute.delete_flavor_extra_specs_property(flavor, prop)
-
-
 @app.task(bind=True, name="osism.tasks.openstack.image_manager")
 def image_manager(
     self,