feat: Add support for 'swarm' backend in schema ,cli and core extensions #149
Conversation
There was a problem hiding this comment.
Thanks for working on that @sanjay7178
I added a few comments here.
also please add some tests on ci
Thanks , sure by this end of day I'll make changes |
|
Hi @sanjay7178 , could you please rebase this branch on top of the upstream/main? I just pushed this new mechanism: #157 you maybe could use that for the node command |
Sure ivan |
| @docparams(doc_node_options) | ||
| def _cmd_node( | ||
| self, | ||
| demote: str = '', |
There was a problem hiding this comment.
now, the positional only is already implemented ..
so it should look like this:
def _cmd_node(
self,
action: str = '',
/,
update: str = '',
options: str = '',
) - > None:There was a problem hiding this comment.
remember to update doc_node_options
There was a problem hiding this comment.
I think we still need to address this. but we can do it in follow up prs
| @docparams(doc_node_options) | ||
| def _cmd_node( | ||
| self, | ||
| demote: str = '', |
There was a problem hiding this comment.
remember to update doc_node_options
…rm init and node commands
…at, size, and type
…ring and formatting
|
@sanjay7178 , please ping me again when this pr is ready for review. |
Sure 😊 |
…me prepending in services list
…gar Swarm and added new tests fixed mypy type errors with tests_sugar.py
|
thanks @sanjay7178 , I will review this pr again tomorrow. |
There was a problem hiding this comment.
thanks for working on that, @sanjay7178
it seems that the tests are not executed in the ci.
could add these tests on ci?
thanks!
Sorry Ivan , I've missed out putting tests in CI , sure I'll do that |
|
This pull request has been marked as stale because it has been |
|
@sanjay7178 could you rebase your branch on top of the upstream main ? |
|
also please remember to add tests in ci |
Sure I would do that |
Sure |
…I extension in Sugar
There was a problem hiding this comment.
thanks @sanjay7178 ! lgtm! appreciate it
maybe we will need some refactoring .. but we can do it as follow ups
thanks , I would do that in this week |
|
🎉 This PR is included in version 1.17.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This PR implements support for Docker Swarm commands in Sugar, expanding its capabilities beyond Docker Compose.
As this PR might be take prolong time to complete support Swarm to Sugar
Solve for #126 and #124
How to test these changes
These are the currently working CLI commands
Pull Request checklists
This PR is a:
PR Checklist:
Sugar Swarm CLI Specific Checklist :
sugar swarm init- Initialize a swarmsugar swarm join- Join a swarm as a node and/or managersugar swarm create- Create a new servicesugar swarm inspect- Display detailed information on servicessugar swarm logs- Fetch service/task logssugar swarm ls- List servicessugar swarm ps- List service taskssugar swarm rm- Remove servicessugar swarm rollback- Revert service configuration changessugar swarm scale- Scale replicated servicessugar swarm update- Update servicessugar swarm node- Manage Swarm nodessugar swarm update- update servicessugar swarm deploy- deploy stackAdditional information
Screenshots attached as far current progress