-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for 'swarm' backend in schema ,cli and core extensions #149
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on that @sanjay7178
I added a few comments here.
also please add some tests on ci
Thanks , sure by this end of day I'll make changes |
Hi @sanjay7178 , could you please rebase this branch on top of the upstream/main? I just pushed this new mechanism: #157 you maybe could use that for the node command |
Sure ivan |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will review more carefully soon ... but I am already sharing some comments here
thanks for working on that
…rm init and node commands
…at, size, and type
…ring and formatting
# Test node commands | ||
sugar ${{ vars.SUGAR_FLAGS }} node ls | ||
NODE_ID=$(docker node ls --format "{{.ID}}" | head -n1) | ||
sugar ${{ vars.SUGAR_FLAGS }} node inspect --options $NODE_ID |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was expecting something like
# sugar ${{ vars.SUGAR_FLAGS }} swarm create --service my-nginx --options --name my-web nginx:latest
# sugar ${{ vars.SUGAR_FLAGS }} swarm ls
# sugar ${{ vars.SUGAR_FLAGS }} swarm inspect --services my-web
# sugar ${{ vars.SUGAR_FLAGS }} swarm ps --services my-web
# sugar ${{ vars.SUGAR_FLAGS }} swarm scale --services my-web --options my-web=2
# sugar ${{ vars.SUGAR_FLAGS }} swarm update --services my-web --options --replicas 1
# Test node commands
sugar ${{ vars.SUGAR_FLAGS }} swarm node ls
NODE_ID=$(docker node ls --format "{{.ID}}" | head -n1)
sugar ${{ vars.SUGAR_FLAGS }} swarm node inspect --options $NODE_ID
in other words, after flag ${{ vars.SUGAR_FLAGS }}
, I would expect the command swarm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sanjay7178 , a friendly reminder about this comment
…ation and parameters
@sanjay7178 , please ping me again when this pr is ready for review. |
Sure 😊 |
This PR implements support for Docker Swarm commands in Sugar, expanding its capabilities beyond Docker Compose.
As this PR might be take prolong time to complete support Swarm to Sugar
Solve for #126 and #124
How to test these changes
These are the currently working CLI commands
Pull Request checklists
This PR is a:
PR Checklist:
Sugar Swarm CLI Specific Checklist :
sugar swarm init
- Initialize a swarmsugar swarm join
- Join a swarm as a node and/or managersugar swarm create
- Create a new servicesugar swarm inspect
- Display detailed information on servicessugar swarm logs
- Fetch service/task logssugar swarm ls
- List servicessugar swarm ps
- List service taskssugar swarm rm
- Remove servicessugar swarm rollback
- Revert service configuration changessugar swarm scale
- Scale replicated servicessugar swarm update
- Update servicessugar swarm node
- Manage Swarm nodesAdditional information
Screenshots attached as far current progress