Skip to content

Possible wrong statement in CI migration test #4102

@lonvia

Description

@lonvia

unrelated to this .. was checking the cicd code to figure out the upper failed job but

https://github.com/osm-search/Nominatim/blob/master/.github/workflows/ci-tests.yml#L412

          - name: Migrate to master version
            run: |
              ./master/bin/nominatim admin --migrate
              ./release/bin/nominatim add-data --file Nominatim/test/testdb/additional_api_test.data.osm

here the migrate job ran ./master/bin/nominatim admin --migrate and then used ./release/bin/nominatim add-data ... again..... so a migration could succeed but the current code path could still fail afterward..cuz this does not actually validate that the migrated installation works with the new code and CI would give a false sense of safety for upgrade compatibility..... so shoudlnt this be /master/bin/nominatim add-data ... ?

Originally posted by @Itz-Agasta in #4101 (comment)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions