unrelated to this .. was checking the cicd code to figure out the upper failed job but
https://github.com/osm-search/Nominatim/blob/master/.github/workflows/ci-tests.yml#L412
- name: Migrate to master version
run: |
./master/bin/nominatim admin --migrate
./release/bin/nominatim add-data --file Nominatim/test/testdb/additional_api_test.data.osm
here the migrate job ran ./master/bin/nominatim admin --migrate and then used ./release/bin/nominatim add-data ... again..... so a migration could succeed but the current code path could still fail afterward..cuz this does not actually validate that the migrated installation works with the new code and CI would give a false sense of safety for upgrade compatibility..... so shoudlnt this be /master/bin/nominatim add-data ... ?
Originally posted by @Itz-Agasta in #4101 (comment)
unrelated to this .. was checking the cicd code to figure out the upper failed job but
https://github.com/osm-search/Nominatim/blob/master/.github/workflows/ci-tests.yml#L412
here the
migratejob ran./master/bin/nominatim admin --migrateand then used./release/bin/nominatim add-data ...again..... so a migration could succeed but the current code path could still fail afterward..cuz this does not actually validate that the migrated installation works with the new code and CI would give a false sense of safety for upgrade compatibility..... so shoudlnt this be/master/bin/nominatim add-data ...?Originally posted by @Itz-Agasta in #4101 (comment)