Analyzer for maxspeed, maxspeed:type cleanup

[wolfbert]

Hi, I'm currently working on tag cleanup for maxspeed, source:maxspeed, maxspeed:type and related tags in Austria (discussion with community is ongoing). As it turns out, the problems exceed my capacity and an Osmose check seems like a good solution.

To give some examples:

• maxspeed and maxspeed:type/source:maxspeed mismatch (i.e. maxspeed=80, source:maxspeed=AT:urban which is 50 by definition)
• maxspeed:type set without maxspeed
• forward/backward inconsistencies
• maxspeed related tags not matching highway type (i.e. AT:rural on highway=residential)
• maxspeed non-numeric (except for walk)
• ... and quite a few more

What would be a good way to proceed with this?

[frodrigo]

There is already an Osmose plugin doing, at least, a part of that: https://github.com/osm-fr/osmose-backend/blob/dev/plugins/TagFix_Maxspeed.py

[wolfbert]

There is already an Osmose plugin doing, at least, a part of that: https://github.com/osm-fr/osmose-backend/blob/dev/plugins/TagFix_Maxspeed.py

Thanks for pointing this out, maybe we can build on that. The values for Austria are incomplete/out of date. Here's the list:

maxspeed:type	maxspeed	Remarks
AT:motorway	130
AT:trunk	100
AT:rural	100
AT:urban	50
AT:bicycle_road	30
AT:zone??	??	15, 20, 30, 40, 50
AT:city_limit??	??	30, 40
AT:shared_zone??	??	20, 30
sign	??	numeric or walk

• maxspeed:type also includes source:maxspeed and the forward and backward variants.
• maxspeed also includes the forward and backward variants.
• maxspeed:type takes precedence over source:maxspeed in case both are set.

I can put together a spec for checks (I can program in Python, but it'll take time to understand how plugins work).

At the moment, I don't see any maxspeed-related issues in Osmose.

Edit: Added concrete figures in table.

[frodrigo]

See the result of this check here https://osmose.openstreetmap.fr/en/issues/open?item=3032&class=303240,303241

Only exception from the default are listed https://github.com/osm-fr/osmose-backend/blob/dev/plugins/TagFix_Maxspeed.py#L30

[wolfbert]

Thanks, I see the list now. To start, it would be the least effort to just update the exception list. Please let me know what else I can do.

Edit 1: if ok with you, I'll submit a pull request, for update and more detailed description.

Edit 2: It turns out that adding logic or country-specific details to TagFix_Maxspeed.py would overcomplicate things and possibly ruin the plugin for communities with different styles. So I've just removed unused values and aim to create an AT-specific plugin step by step that can handle local specifics.

[Famlam]

Edit 2: It turns out that adding logic or country-specific details to TagFix_Maxspeed.py would overcomplicate things and possibly ruin the plugin for communities with different styles. So I've just removed unused values and aim to create an AT-specific plugin step by step that can handle local specifics.

Note that, if the tests are simple (e.g. if you only check tags on a single element per rule) you can also make a mapcss rule set (see https://josm.openstreetmap.de/wiki/Rules & https://josm.openstreetmap.de/wiki/Help/Styles/MapCSSImplementation), which we could import into Osmose. That way both JOSM users as well as Osmose users can get the results.

[wolfbert]

Thanks for pointing this out. It does make development more complex though (multiple languages and systems, plugin generation, testing). I'll look into it, but the more sophisticated checks will require code.

[frodrigo]

MapCSS is more simple. You can even check it in JOSM.