Skip to content

Commit 5b4e034

Browse files
authored
fix: add missing check for key pagination (#643)
* fix: add missing check for key pagination * chore: add change log.md
1 parent ae97fc8 commit 5b4e034

File tree

2 files changed

+18
-2
lines changed

2 files changed

+18
-2
lines changed

CHANGELOG.md

Lines changed: 14 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,9 +38,13 @@ Ref: https://keepachangelog.com/en/1.0.0/
3838

3939
## Osmosis Specific Info
4040

41-
## v28
41+
## v29
4242

43-
## [v0.50.11-v28-osmo-1](https://github.com/osmosis-labs/cosmos-sdk/releases/tag/v0.50.11-v28-osmo-1)
43+
## [v0.50.11-v28-osmo-3](https://github.com/osmosis-labs/cosmos-sdk/releases/tag/v0.50.11-v28-osmo-3)
44+
45+
This v0.50.x branch was created at the [eb1a8e88a4ddf77bc2fe235fc07c57016b7386f0](https://github.com/cosmos/cosmos-sdk/commit/eb1a8e88a4ddf77bc2fe235fc07c57016b7386f0) commit of the [release/v0.50.x](https://github.com/cosmos/cosmos-sdk/commits/release/v0.50.x/) branch. If you catch this fork up with the latest changes from upstream, please start at the commit after the one mentioned above, and work your way to the tip (or desired commit) of the upstream branch. Then, update this message with the new commit hash. Also, when you add a new PRs to this branch on Osmosis and it is not yet upstreamed, make sure you add it both directly below AND in the respective release section of this file.
46+
47+
## [v0.50.11-v28-osmo-2](https://github.com/osmosis-labs/cosmos-sdk/releases/tag/v0.50.11-v28-osmo-2)
4448

4549
This v0.50.x branch was created at the [eb1a8e88a4ddf77bc2fe235fc07c57016b7386f0](https://github.com/cosmos/cosmos-sdk/commit/eb1a8e88a4ddf77bc2fe235fc07c57016b7386f0) commit of the [release/v0.50.x](https://github.com/cosmos/cosmos-sdk/commits/release/v0.50.x/) branch. If you catch this fork up with the latest changes from upstream, please start at the commit after the one mentioned above, and work your way to the tip (or desired commit) of the upstream branch. Then, update this message with the new commit hash. Also, when you add a new PRs to this branch on Osmosis and it is not yet upstreamed, make sure you add it both directly below AND in the respective release section of this file.
4650

@@ -70,6 +74,7 @@ This v0.50.x branch was created at the [eb1a8e88a4ddf77bc2fe235fc07c57016b7386f0
7074

7175
* Gov proposals fix
7276
* [#642](https://github.com/osmosis-labs/cosmos-sdk/pull/642) fix: gov proposal fix for missing codec value
77+
* [#643](https://github.com/osmosis-labs/cosmos-sdk/pull/643) fix: missing case for key pagination
7378

7479
* Supply offset fix
7580
* [#629](https://github.com/osmosis-labs/cosmos-sdk/pull/629) fix: add old supply offset functions
@@ -109,6 +114,13 @@ This v0.50.x branch was created at the [eb1a8e88a4ddf77bc2fe235fc07c57016b7386f0
109114
* Cliff Vesting
110115
* [#271](https://github.com/osmosis-labs/cosmos-sdk/pull/271) Bring back cliff vesting CLI command
111116

117+
## v28
118+
119+
## [v0.50.11-v28-osmo-1](https://github.com/osmosis-labs/cosmos-sdk/releases/tag/v0.50.11-v28-osmo-1)
120+
121+
This v0.50.x branch was created at the [eb1a8e88a4ddf77bc2fe235fc07c57016b7386f0](https://github.com/cosmos/cosmos-sdk/commit/eb1a8e88a4ddf77bc2fe235fc07c57016b7386f0) commit of the [release/v0.50.x](https://github.com/cosmos/cosmos-sdk/commits/release/v0.50.x/) branch. If you catch this fork up with the latest changes from upstream, please start at the commit after the one mentioned above, and work your way to the tip (or desired commit) of the upstream branch. Then, update this message with the new commit hash. Also, when you add a new PRs to this branch on Osmosis and it is not yet upstreamed, make sure you add it both directly below AND in the respective release section of this file.
122+
123+
112124
## v27
113125

114126
## [v0.50.10-v27-osmo-1](https://github.com/osmosis-labs/cosmos-sdk/releases/tag/v0.50.10-v27-osmo-1)

x/gov/keeper/collections_pagination_gov.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -300,6 +300,10 @@ func collFilteredPaginateByKey[K, V any, C query.Collection[K, V], T any](
300300

301301
kv, err := iterator.KeyValue()
302302
if err != nil {
303+
if strings.Contains(err.Error(), "no concrete type registered for type URL") {
304+
// URL /osmosis.concentratedliquidity.v1beta1.CreateConcentratedLiquidityPoolsProposal
305+
continue
306+
}
303307
return nil, nil, err
304308
}
305309
// if no predicate is specified then we just append the result

0 commit comments

Comments
 (0)