Less sensitive error handling for failed swap

Author: JohnnyWyles

x/protorev/keeper/protorev.go

@@ -171,7 +171,7 @@ func (k Keeper) GetPoolForDenomPair(ctx sdk.Context, baseDenom, denomToMatch str
 func (k Keeper) GetPoolForDenomPairNoOrder(ctx sdk.Context, tokenA, tokenB string) (uint64, error) {
 	poolId, err := k.GetPoolForDenomPair(ctx, tokenA, tokenB)
 	if err != nil {
-		if errors.Is(err, types.NoPoolForDenomPairError{BaseDenom: tokenA, MatchDenom: tokenB}) {
+		if errors.Is(err, types.NoPoolForDenomPairError{}) {
 			// Attempt changing base and match denoms.
 			poolId, err = k.GetPoolForDenomPair(ctx, tokenB, tokenA)
 			if err != nil {

x/protorev/types/errors.go

@@ -14,4 +14,10 @@ func (e NoPoolForDenomPairError) Error() string {
 	return fmt.Sprintf("highest liquidity pool between base %s and match denom %s not found", e.BaseDenom, e.MatchDenom)
 }
 
+// Is implements error matching for errors.Is to match any NoPoolForDenomPairError regardless of field values
+func (e NoPoolForDenomPairError) Is(target error) bool {
+	_, ok := target.(NoPoolForDenomPairError)
+	return ok
+}
+
 var ErrRouteDoubleContainsPool = errors.New("cannot be trading on the same pool twice")