Skip to content

Commit cc1ac87

Browse files
committed
api: Fix RemovePrivate Enum
Use _UNSPECIFIED prefix for zero. Signed-off-by: FUJITA Tomonori <[email protected]>
1 parent 1f48585 commit cc1ac87

File tree

5 files changed

+31
-32
lines changed

5 files changed

+31
-32
lines changed

api/gobgp.pb.go

Lines changed: 18 additions & 19 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

cmd/gobgp/neighbor.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -294,9 +294,9 @@ func showNeighbor(args []string) error {
294294
elems = append(elems, fmt.Sprintf("Allow Own AS: %d", as))
295295
}
296296
switch p.Conf.RemovePrivate {
297-
case api.RemovePrivate_REMOVE_ALL:
297+
case api.RemovePrivate_REMOVE_PRIVATE_ALL:
298298
elems = append(elems, "Remove private AS: all")
299-
case api.RemovePrivate_REPLACE:
299+
case api.RemovePrivate_REMOVE_PRIVATE_REPLACE:
300300
elems = append(elems, "Remove private AS: replace")
301301
}
302302
if p.Conf.ReplacePeerAsn {
@@ -1390,9 +1390,9 @@ func modNeighbor(cmdType string, args []string) error {
13901390
if option, ok := m["remove-private-as"]; ok {
13911391
switch option[0] {
13921392
case "all":
1393-
peer.Conf.RemovePrivate = api.RemovePrivate_REMOVE_ALL
1393+
peer.Conf.RemovePrivate = api.RemovePrivate_REMOVE_PRIVATE_ALL
13941394
case "replace":
1395-
peer.Conf.RemovePrivate = api.RemovePrivate_REPLACE
1395+
peer.Conf.RemovePrivate = api.RemovePrivate_REMOVE_PRIVATE_REPLACE
13961396
default:
13971397
return fmt.Errorf("invalid remove-private-as value: all or replace")
13981398
}

pkg/config/oc/util.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -459,9 +459,9 @@ func NewPeerFromConfigStruct(pconf *Neighbor) *api.Peer {
459459
var removePrivate api.RemovePrivate
460460
switch pconf.Config.RemovePrivateAs {
461461
case REMOVE_PRIVATE_AS_OPTION_ALL:
462-
removePrivate = api.RemovePrivate_REMOVE_ALL
462+
removePrivate = api.RemovePrivate_REMOVE_PRIVATE_ALL
463463
case REMOVE_PRIVATE_AS_OPTION_REPLACE:
464-
removePrivate = api.RemovePrivate_REPLACE
464+
removePrivate = api.RemovePrivate_REMOVE_PRIVATE_REPLACE
465465
}
466466
var admin_state api.PeerState_AdminState
467467
switch s.AdminState {

pkg/server/grpc_server.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -695,9 +695,9 @@ func newNeighborFromAPIStruct(a *api.Peer) (*oc.Neighbor, error) {
695695
pconf.Config.SendSoftwareVersion = a.Conf.SendSoftwareVersion
696696

697697
switch a.Conf.RemovePrivate {
698-
case api.RemovePrivate_REMOVE_ALL:
698+
case api.RemovePrivate_REMOVE_PRIVATE_ALL:
699699
pconf.Config.RemovePrivateAs = oc.REMOVE_PRIVATE_AS_OPTION_ALL
700-
case api.RemovePrivate_REPLACE:
700+
case api.RemovePrivate_REMOVE_PRIVATE_REPLACE:
701701
pconf.Config.RemovePrivateAs = oc.REMOVE_PRIVATE_AS_OPTION_REPLACE
702702
}
703703

@@ -822,9 +822,9 @@ func newPeerGroupFromAPIStruct(a *api.PeerGroup) (*oc.PeerGroup, error) {
822822
pconf.Config.SendSoftwareVersion = a.Conf.SendSoftwareVersion
823823

824824
switch a.Conf.RemovePrivate {
825-
case api.RemovePrivate_REMOVE_ALL:
825+
case api.RemovePrivate_REMOVE_PRIVATE_ALL:
826826
pconf.Config.RemovePrivateAs = oc.REMOVE_PRIVATE_AS_OPTION_ALL
827-
case api.RemovePrivate_REPLACE:
827+
case api.RemovePrivate_REMOVE_PRIVATE_REPLACE:
828828
pconf.Config.RemovePrivateAs = oc.REMOVE_PRIVATE_AS_OPTION_REPLACE
829829
}
830830

proto/api/gobgp.proto

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -737,9 +737,9 @@ enum PeerType {
737737
}
738738

739739
enum RemovePrivate {
740-
REMOVE_NONE = 0;
741-
REMOVE_ALL = 1;
742-
REPLACE = 2;
740+
REMOVE_PRIVATE_UNSPECIFIED = 0;
741+
REMOVE_PRIVATE_ALL = 1;
742+
REMOVE_PRIVATE_REPLACE = 2;
743743
}
744744

745745
message PeerConf {

0 commit comments

Comments
 (0)