Set state properties required for calculating shares, before doing so

Author: krokosik

src/pages/add.tsx

@@ -91,18 +91,18 @@ const AddPage: NextPageWithUser<{
     }
 
     expenseQuery.data.group && setGroup(expenseQuery.data.group);
+    setPaidBy(expenseQuery.data.paidByUser);
+    setCurrency(expenseQuery.data.currency as CurrencyCode);
+    setAmountStr((Number(expenseQuery.data.amount) / 100).toString());
+    setDescription(expenseQuery.data.name);
+    setAmount(expenseQuery.data.amount);
     setParticipants(
       expenseQuery.data.expenseParticipants.map((ep) => ({
         ...ep.user,
         amount: ep.amount,
       })),
       expenseQuery.data.splitType,
     );
-    setCurrency(expenseQuery.data.currency as CurrencyCode);
-    setAmountStr((Number(expenseQuery.data.amount) / 100).toString());
-    setDescription(expenseQuery.data.name);
-    setPaidBy(expenseQuery.data.paidByUser);
-    setAmount(expenseQuery.data.amount);
     useAddExpenseStore.setState({ showFriends: false });
     setExpenseDate(expenseQuery.data.expenseDate);
     // eslint-disable-next-line react-hooks/exhaustive-deps

src/store/addStore.ts

@@ -389,7 +389,7 @@ export function calculateSplitShareBasedOnAmount(
                 Math.round(
                   (Math.abs(
                     paidBy?.id !== p.id
-                      ? Number(p.amount) ?? 0
+                      ? (Number(p.amount) ?? 0)
                       : amountNum - (Number(p.amount) ?? 0),
                   ) /
                     amountNum) *
@@ -403,7 +403,9 @@ export function calculateSplitShareBasedOnAmount(
     case SplitType.EXACT:
       participants.forEach((p) => {
         splitShares[p.id]![splitType] =
-          paidBy?.id !== p.id ? BigMath.abs(p.amount ?? 0n) : amount - BigMath.abs(p.amount ?? 0n);
+          paidBy?.id !== p.id
+            ? BigMath.abs(p.amount ?? 0n)
+            : BigMath.abs(amount - (p.amount ?? 0n));
       });
 
       break;