Check at the start of the function

oss-patch · web-flow · commit 21df0f96f47e · 2025-01-31T11:22:39.000+08:00
diff --git a/Packet++/src/GreLayer.cpp b/Packet++/src/GreLayer.cpp
@@ -590,12 +590,12 @@ namespace pcpp
 
 	void PPP_PPTPLayer::computeCalculateFields()
 	{
-		ppp_pptp_header* header = getPPP_PPTPHeader();
 		if (m_DataLen < sizeof(ppp_pptp_header))
 		{
 			PCPP_LOG_ERROR("Insufficient data length for PPP_PPTP header");
 			return;
 		}
+		ppp_pptp_header* header = getPPP_PPTPHeader();
 		if (m_NextLayer != nullptr)
 		{
 			switch (m_NextLayer->getProtocol())

Original file line number	Diff line number	Diff line change
`@@ -590,12 +590,12 @@ namespace pcpp`
`590`	`590`
`591`	`591`	`void PPP_PPTPLayer::computeCalculateFields()`
`592`	`592`	`{`
`593`		`- ppp_pptp_header* header = getPPP_PPTPHeader();`
`594`	`593`	`if (m_DataLen < sizeof(ppp_pptp_header))`
`595`	`594`	`{`
`596`	`595`	`PCPP_LOG_ERROR("Insufficient data length for PPP_PPTP header");`
`597`	`596`	`return;`
`598`	`597`	`}`
	`598`	`+ ppp_pptp_header* header = getPPP_PPTPHeader();`
`599`	`599`	`if (m_NextLayer != nullptr)`
`600`	`600`	`{`
`601`	`601`	`switch (m_NextLayer->getProtocol())`