Fix the last valid byte in buf

oss-patch · web-flow · commit 634e0960a567 · 2025-01-15T20:38:07.000+08:00
diff --git a/src/H5Faccum.c b/src/H5Faccum.c
@@ -883,7 +883,7 @@ H5F__accum_free(H5F_shared_t *f_sh, H5FD_mem_t H5_ATTR_UNUSED type, haddr_t addr
 
                 /* Ensure that the memmove operation won't overflow past the buffer's allocated size */
                 if (H5_IS_BUFFER_OVERFLOW(accum->buf + overlap_size, new_accum_size,
-                                          accum->buf + accum->alloc_size)) {
+                                          accum->buf + accum->alloc_size - 1)) {
                     HGOTO_ERROR(H5E_ARGS, H5E_BADVALUE, FAIL, "memmove operation would overflow buffer");
                 }
                 /* Move the accumulator buffer information to eliminate the freed block */

Original file line number	Diff line number	Diff line change
`@@ -883,7 +883,7 @@ H5F__accum_free(H5F_shared_t *f_sh, H5FD_mem_t H5_ATTR_UNUSED type, haddr_t addr`
`883`	`883`
`884`	`884`	`/* Ensure that the memmove operation won't overflow past the buffer's allocated size */`
`885`	`885`	`if (H5_IS_BUFFER_OVERFLOW(accum->buf + overlap_size, new_accum_size,`
`886`		`- accum->buf + accum->alloc_size)) {`
	`886`	`+ accum->buf + accum->alloc_size - 1)) {`
`887`	`887`	`HGOTO_ERROR(H5E_ARGS, H5E_BADVALUE, FAIL, "memmove operation would overflow buffer");`
`888`	`888`	`}`
`889`	`889`	`/* Move the accumulator buffer information to eliminate the freed block */`