Skip to content

Commit 0211d1d

Browse files
committed
test(ort-utils): Use a ConcurrentHashMap for requests
Be on the safe side for parallel put / get requests. Signed-off-by: Sebastian Schuberth <sebastian@doubleopen.io>
1 parent 06ea468 commit 0211d1d

2 files changed

Lines changed: 4 additions & 2 deletions

File tree

utils/ort/src/funTest/kotlin/storage/HttpFileStorageFunTest.kt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,12 +34,13 @@ import java.io.IOException
3434
import java.net.HttpURLConnection
3535
import java.net.InetAddress
3636
import java.net.InetSocketAddress
37+
import java.util.concurrent.ConcurrentHashMap
3738

3839
class HttpFileStorageFunTest : WordSpec() {
3940
private val loopback = InetAddress.getLoopbackAddress()
4041

4142
private val handler = object : HttpHandler {
42-
val requests = mutableMapOf<String, String>()
43+
val requests = ConcurrentHashMap<String, String>()
4344

4445
override fun handle(exchange: HttpExchange) {
4546
when (exchange.requestMethod) {

utils/ort/src/funTest/kotlin/storage/S3FileStorageFunTest.kt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ import io.kotest.matchers.shouldBe
3434
import java.net.HttpURLConnection
3535
import java.net.InetAddress
3636
import java.net.InetSocketAddress
37+
import java.util.concurrent.ConcurrentHashMap
3738

3839
class S3FileStorageFunTest : WordSpec() {
3940
private val loopback = InetAddress.getLoopbackAddress()
@@ -42,7 +43,7 @@ class S3FileStorageFunTest : WordSpec() {
4243
private val bucket = "ort-scan-results"
4344

4445
private val handler = object : HttpHandler {
45-
val requests = mutableMapOf<String, String>()
46+
val requests = ConcurrentHashMap<String, String>()
4647

4748
override fun handle(exchange: HttpExchange) {
4849
when (exchange.requestMethod) {

0 commit comments

Comments
 (0)