build(gradle)!: Move script definitions to script-utils

Modules that contain custom scripts, for example as resources, must
depend on a module with the script definitions for IDE auto-completion
to work. Definitions and scripts cannot reside in the same module for that
purpose.

After this change, do the following in IntelliJ IDEA:
- Gradle sync
- Go to global settings
- Search the "kotlin SCripting" section
- Expand "Custom Definitions" at the bottom
- Click on "Search Definitions"

That should make auto-completion for custom scripts work.

BREAKING CHANGE: Programmatic users of script definitions have to adapt to
the new artifact names.

Signed-off-by: Sebastian Schuberth <sebastian@doubleopen.io>

Author: sschuberth

evaluator/build.gradle.kts

@@ -32,7 +32,6 @@ plugins {
 }
 
 dependencies {
-    api("org.jetbrains.kotlin:kotlin-scripting-common")
     api(libs.kotlinx.serialization.core)
     api(projects.model)
     api(projects.utils.scriptUtils)
@@ -50,6 +49,8 @@ dependencies {
 
     testImplementation(libs.mockk)
     testImplementation(projects.utils.testUtils)
+
+    kotlinScriptDef(projects.utils.scriptUtils)
 }
 
 tasks.register<Download>("updateOsadlMatrix") {

evaluator/src/main/kotlin/Evaluator.kt

@@ -35,6 +35,7 @@ import org.ossreviewtoolkit.model.utils.DefaultResolutionProvider
 import org.ossreviewtoolkit.model.utils.ResolutionProvider
 import org.ossreviewtoolkit.model.utils.createLicenseInfoResolver
 import org.ossreviewtoolkit.utils.ort.Environment
+import org.ossreviewtoolkit.utils.script.RulesScriptTemplate
 import org.ossreviewtoolkit.utils.script.ScriptRunner
 
 class Evaluator(

notifier/build.gradle.kts

@@ -23,23 +23,23 @@ plugins {
 }
 
 dependencies {
-    api("org.jetbrains.kotlin:kotlin-scripting-common")
     api(libs.jiraRestClient.api)
     api(projects.model)
     api(projects.utils.scriptUtils)
 
     implementation("org.jetbrains.kotlin:kotlin-scripting-jvm-host")
     implementation(libs.jakartaMail)
-    implementation(libs.jerseyCommon)
-
     implementation(libs.jiraRestClient.app) {
         exclude("org.apache.logging.log4j", "log4j-slf4j2-impl")
             .because("the SLF4J implementation from Log4j 2 is used")
     }
-
     implementation(projects.utils.commonUtils)
 
+    runtimeOnly(libs.jerseyCommon)
+
     testImplementation(libs.greenmail)
     testImplementation(libs.mockk)
     testImplementation(libs.wiremock)
+
+    kotlinScriptDef(projects.utils.scriptUtils)
 }

notifier/src/main/kotlin/Notifier.kt

@@ -36,6 +36,7 @@ import org.ossreviewtoolkit.model.utils.DefaultResolutionProvider
 import org.ossreviewtoolkit.model.utils.ResolutionProvider
 import org.ossreviewtoolkit.notifier.modules.JiraNotifier
 import org.ossreviewtoolkit.notifier.modules.MailNotifier
+import org.ossreviewtoolkit.utils.script.NotificationsScriptTemplate
 import org.ossreviewtoolkit.utils.script.ScriptRunner
 
 class Notifier(

reporter/build.gradle.kts

@@ -26,7 +26,6 @@ plugins {
 }
 
 dependencies {
-    api("org.jetbrains.kotlin:kotlin-scripting-common")
     api(projects.model)
     api(projects.plugins.api)
     api(projects.plugins.licenseFactProviders.licenseFactProviderApi)
@@ -37,4 +36,6 @@ dependencies {
     funTestImplementation(testFixtures(project))
 
     testFixturesImplementation(projects.utils.testUtils)
+
+    kotlinScriptDef(projects.utils.scriptUtils)
 }

reporter/src/main/kotlin/HowToFixTextProvider.kt

@@ -28,6 +28,7 @@ import kotlin.script.experimental.jvmhost.createJvmCompilationConfigurationFromT
 
 import org.ossreviewtoolkit.model.Issue
 import org.ossreviewtoolkit.model.OrtResult
+import org.ossreviewtoolkit.utils.script.HowToFixTextProviderScriptTemplate
 import org.ossreviewtoolkit.utils.script.ScriptRunner
 
 /**

utils/script/build.gradle.kts

@@ -24,6 +24,7 @@ plugins {
 
 dependencies {
     api("org.jetbrains.kotlin:kotlin-scripting-common")
+    api(projects.model)
 
     implementation("org.jetbrains.kotlin:kotlin-scripting-jvm")
     implementation("org.jetbrains.kotlin:kotlin-scripting-jvm-host")

…in/HowToFixTextProviderScriptTemplate.kt …in/HowToFixTextProviderScriptTemplate.ktreporter/src/main/kotlin/HowToFixTextProviderScriptTemplate.kt renamed to utils/script/src/main/kotlin/HowToFixTextProviderScriptTemplate.kt reporter/src/main/kotlin/HowToFixTextProviderScriptTemplate.kt renamed to utils/script/src/main/kotlin/HowToFixTextProviderScriptTemplate.kt

@@ -17,14 +17,13 @@
  * License-Filename: LICENSE
  */
 
-package org.ossreviewtoolkit.reporter
+package org.ossreviewtoolkit.utils.script
 
 import kotlin.script.experimental.annotations.KotlinScript
 import kotlin.script.experimental.api.ScriptCompilationConfiguration
 import kotlin.script.experimental.api.defaultImports
 
 import org.ossreviewtoolkit.model.OrtResult
-import org.ossreviewtoolkit.utils.script.OrtScriptCompilationConfiguration
 
 @KotlinScript(
     displayName = "ORT How-To-Fix-Text-Provider Script",

…in/kotlin/NotificationsScriptTemplate.kt …in/kotlin/NotificationsScriptTemplate.ktnotifier/src/main/kotlin/NotificationsScriptTemplate.kt renamed to utils/script/src/main/kotlin/NotificationsScriptTemplate.kt notifier/src/main/kotlin/NotificationsScriptTemplate.kt renamed to utils/script/src/main/kotlin/NotificationsScriptTemplate.kt

@@ -17,14 +17,13 @@
  * License-Filename: LICENSE
  */
 
-package org.ossreviewtoolkit.notifier
+package org.ossreviewtoolkit.utils.script
 
 import kotlin.script.experimental.annotations.KotlinScript
 import kotlin.script.experimental.api.ScriptCompilationConfiguration
 import kotlin.script.experimental.api.defaultImports
 
 import org.ossreviewtoolkit.model.OrtResult
-import org.ossreviewtoolkit.utils.script.OrtScriptCompilationConfiguration
 
 @KotlinScript(
     displayName = "ORT Notifications Script",

…r/src/main/kotlin/RulesScriptTemplate.kt …t/src/main/kotlin/RulesScriptTemplate.ktevaluator/src/main/kotlin/RulesScriptTemplate.kt renamed to utils/script/src/main/kotlin/RulesScriptTemplate.kt evaluator/src/main/kotlin/RulesScriptTemplate.kt renamed to utils/script/src/main/kotlin/RulesScriptTemplate.kt

@@ -17,7 +17,7 @@
  * License-Filename: LICENSE
  */
 
-package org.ossreviewtoolkit.evaluator
+package org.ossreviewtoolkit.utils.script
 
 import java.time.Instant
 
@@ -30,7 +30,6 @@ import org.ossreviewtoolkit.model.RuleViolation
 import org.ossreviewtoolkit.model.licenses.LicenseClassifications
 import org.ossreviewtoolkit.model.licenses.LicenseInfoResolver
 import org.ossreviewtoolkit.model.utils.ResolutionProvider
-import org.ossreviewtoolkit.utils.script.OrtScriptCompilationConfiguration
 
 @KotlinScript(
     displayName = "ORT Evaluator Rules Script",