Skip to content

Commit 57d7300

Browse files
committed
fix(model): Skip excluded projects in getDependencies when omitExcluded is true
Previously, getDependencies(omitExcluded=true) only filtered excluded packages from results but still traversed all projects. This caused inconsistencies when dependency edges only exist in excluded projects (e.g., test-only submodules). Now excluded projects are also skipped during traversal, ensuring dependencies only reachable through excluded projects are not discovered. Signed-off-by: Kai Hodžić <hodzic.e.k@outlook.com>
1 parent 5ddb211 commit 57d7300

1 file changed

Lines changed: 3 additions & 1 deletion

File tree

model/src/main/kotlin/OrtResult.kt

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -243,7 +243,9 @@ data class OrtResult(
243243
val dependencies = mutableSetOf<Identifier>()
244244
val matcher = DependencyNavigator.MATCH_ALL.takeUnless { omitExcluded } ?: { !isExcluded(it.id) }
245245

246-
getProjects().forEach { project ->
246+
val projects = if (omitExcluded) getProjects().filter { !isExcluded(it.id) } else getProjects()
247+
248+
projects.forEach { project ->
247249
if (project.id == id) {
248250
dependencies += dependencyNavigator.projectDependencies(project, maxLevel, matcher)
249251
}

0 commit comments

Comments
 (0)