fix(fossid-webapp): comments can be an empty array

FossId versions before 24.3.2 did not return the "comments" property when
it was empty. Now it returns '[]' for this property value which is
problematic, as it introduces polymorphism (a non-empty 'comments' property
contains a map of integer to object).
According to FossId support, "This is the default behaviour of the
json_encode() function in PHP. An empty [] or empty {} should be handled in
a similar way in integrations as they both represent the lack of elements".
In all cases, ORT must support this behavior.

Signed-off-by: Nicolas Nobelis <nicolas.nobelis@bosch.com>

Author: nnobelis

clients/fossid-webapp/src/main/kotlin/model/identification/markedAsIdentified/MarkedAsIdentifiedFile.kt

@@ -21,14 +21,15 @@ package org.ossreviewtoolkit.clients.fossid.model.identification.markedAsIdentif
 
 import com.fasterxml.jackson.annotation.JsonUnwrapped
 
+import org.ossreviewtoolkit.clients.fossid.PolymorphicData
 import org.ossreviewtoolkit.clients.fossid.model.identification.common.Component
 import org.ossreviewtoolkit.clients.fossid.model.summary.License
 import org.ossreviewtoolkit.clients.fossid.model.summary.Summarizable
 import org.ossreviewtoolkit.clients.fossid.model.summary.SummaryIdentifiedFile
 
 data class MarkedAsIdentifiedFile(
     val comment: String?,
-    val comments: Map<Int, Comment> = emptyMap(),
+    val comments: PolymorphicData<Map<Int, Comment>> = PolymorphicData(emptyMap()),
 
     val identificationId: Int,
 

clients/fossid-webapp/src/test/resources/return-type/__files/body-list_scan_for_project_not_empty.json

@@ -66,6 +66,36 @@
           "component_identified_date": "2025-12-08 09:13:10"
         }
       }
+    },
+    "4": {
+      "row_id": "2",
+      "file_id": "4611459",
+      "file_path": "src/main/java/com/example/client/response/ReportRequest.java",
+      "is_distributed": "1",
+      "file_md5": "b8a8c00bf1dea4d52cb6a842b7affe08",
+      "file_sha1": "da7c6657784025f38d5bb64733004ca01aa17ac0",
+      "file_sha256": "af0254a01efd2ff2bdabce1299d8232625025330c711cf8bece7e566596aea2f",
+      "file_size": "377",
+      "identification_id": "29648306",
+      "identification_copyright": null,
+      "components": {
+        "352": {
+          "identification_id": 29648306,
+          "component_id": 352,
+          "component_name": "Original Code",
+          "component_version": "Unspecified",
+          "component_copyright": null,
+          "component_cpe": null,
+          "component_license_name": "[template] Basic Proprietary Commercial License",
+          "component_license_identifier": "[template] Basic Proprietary Commercial License",
+          "component_license_is_foss": 0,
+          "component_license_is_spdx_standard": 0,
+          "component_include_in_report": 1,
+          "component_is_copyleft": 0,
+          "component_identified_date": "2025-12-08 09:13:10"
+        }
+      },
+      "comments": []
     }
   }
 }

plugins/scanners/fossid/src/main/kotlin/FossIdScanResults.kt

@@ -147,7 +147,7 @@ internal fun <T : Summarizable> List<T>.mapSummary(
         var fileComment: OrtComment? = null
 
         if (summarizable is MarkedAsIdentifiedFile) {
-            summarizable.comments.values.firstOrNull {
+            summarizable.comments.value?.values?.firstOrNull {
                 ORT_NAME in it.comment
             }?.also {
                 runCatching {
@@ -453,7 +453,7 @@ internal fun listUnmatchedSnippetChoices(
             it.given.sourceLocation.path == markedFileNameWithoutPrefix
         }
 
-        val comment = markedAsIdentifiedFile.comments.values.firstOrNull {
+        val comment = markedAsIdentifiedFile.comments.value?.values?.firstOrNull {
             ORT_NAME in it.comment
         }?.runCatching {
             jsonMapper.readValue(this.comment, OrtComment::class.java)

plugins/scanners/fossid/src/test/kotlin/TestUtils.kt

@@ -415,7 +415,7 @@ internal fun createMarkAsIdentifiedFile(
 
     return MarkedAsIdentifiedFile(
         comment = "comment",
-        comments = if (comment == null) emptyMap() else mapOf(1 to Comment(1, 1, comment)),
+        comments = PolymorphicData(if (comment == null) emptyMap() else mapOf(1 to Comment(1, 1, comment))),
         identificationId = 1,
         identificationCopyright = "copyright",
         isDistributed = 1,