feat(model): Support aliases for renamed identifier types

Add a map to define aliases for renamed identifier types and use that
when matching types.

Ideally, the aliases should come from the package manager
implementations where the renaming takes place, but that is not possible
because the matching logic is inside the `model` module which is a
dependency of the package manager plugins.

Signed-off-by: Martin Nonnenmacher <[email protected]>

Author: mnonnenmacher

model/src/main/kotlin/Identifier.kt

@@ -126,8 +126,22 @@ data class Identifier(
         sanitizedProperties.joinToString(separator) { it.encodeOr(emptyValue) }
 }
 
+/**
+ * A map of lowercase aliases for types that were renamed.
+ */
+private val typeAliases = mapOf(
+    "spdxdocument" to "spdxdocumentfile"
+)
+
 /**
  * Return whether the [type][Identifier.type] of this [Identifier] matches the type of [other] by comparing them
- * case-insensitively.
+ * case-insensitively. Additionally, the [typeAliases] are considered.
  */
-fun Identifier.typeMatches(other: Identifier) = type.equals(other.type, ignoreCase = true)
+fun Identifier.typeMatches(other: Identifier): Boolean {
+    val thisType = type.lowercase()
+    val otherType = other.type.lowercase()
+
+    return thisType == otherType ||
+        typeAliases[thisType] == otherType ||
+        typeAliases[otherType] == thisType
+}

model/src/test/kotlin/IdentifierTest.kt

@@ -147,5 +147,12 @@ class IdentifierTest : WordSpec({
             val id = Identifier.EMPTY.copy(type = "type")
             id.typeMatches(Identifier.EMPTY.copy(type = "other")) shouldBe false
         }
+
+        "return true if the type matches an alias" {
+            val id = Identifier.EMPTY.copy(type = "SpdxDocument")
+            val otherId = Identifier.EMPTY.copy(type = "spdxdocumentfile")
+            id.typeMatches(otherId) shouldBe true
+            otherId.typeMatches(id) shouldBe true
+        }
     }
 })