Skip to content

Commit fe47add

Browse files
committed
refactor(gradle)!: Split out authentication utilities to a new module
This allows for more fine-granular dependency management. BREAKING CHANGE: Programmatic users might need to depend on `authorization-utils` instead of / in addition to `ort-utils` now. Signed-off-by: Sebastian Schuberth <sebastian@doubleopen.io>
1 parent 25df745 commit fe47add

30 files changed

Lines changed: 69 additions & 26 deletions

File tree

plugins/package-managers/conan/build.gradle.kts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ dependencies {
3434
implementation(libs.kotlinx.serialization.yaml)
3535
implementation(libs.semver4j)
3636
implementation(projects.downloader)
37+
implementation(projects.utils.authenticationUtils)
3738
implementation(projects.utils.commonUtils)
3839
implementation(projects.utils.ortUtils)
3940

plugins/package-managers/conan/src/main/kotlin/Conan.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,7 @@ import org.ossreviewtoolkit.model.config.Includes
5555
import org.ossreviewtoolkit.plugins.api.OrtPlugin
5656
import org.ossreviewtoolkit.plugins.api.OrtPluginOption
5757
import org.ossreviewtoolkit.plugins.api.PluginDescriptor
58+
import org.ossreviewtoolkit.utils.authentication.requestPasswordAuthentication
5859
import org.ossreviewtoolkit.utils.common.CommandLineTool
5960
import org.ossreviewtoolkit.utils.common.alsoIfNull
6061
import org.ossreviewtoolkit.utils.common.div
@@ -64,7 +65,6 @@ import org.ossreviewtoolkit.utils.common.stashFiles
6465
import org.ossreviewtoolkit.utils.common.toUri
6566
import org.ossreviewtoolkit.utils.ort.ORT_CONFIG_FILENAME
6667
import org.ossreviewtoolkit.utils.ort.createOrtTempDir
67-
import org.ossreviewtoolkit.utils.ort.requestPasswordAuthentication
6868

6969
import org.semver4j.range.RangeList
7070
import org.semver4j.range.RangeListFactory

plugins/package-managers/maven/build.gradle.kts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@ dependencies {
3737
implementation(libs.kotlinx.serialization.json)
3838
implementation(libs.maven.embedder)
3939
implementation(projects.downloader)
40+
implementation(projects.utils.authenticationUtils)
4041
implementation(projects.utils.commonUtils)
4142

4243
funTestImplementation(testFixtures(projects.analyzer))

plugins/package-managers/maven/src/main/kotlin/utils/MavenSupport.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -89,12 +89,12 @@ import org.ossreviewtoolkit.model.RemoteArtifact
8989
import org.ossreviewtoolkit.model.fromYaml
9090
import org.ossreviewtoolkit.model.toYaml
9191
import org.ossreviewtoolkit.plugins.packagemanagers.maven.PACKAGE_TYPE
92+
import org.ossreviewtoolkit.utils.authentication.OrtAuthenticator
93+
import org.ossreviewtoolkit.utils.authentication.OrtProxySelector
9294
import org.ossreviewtoolkit.utils.common.collectMessages
9395
import org.ossreviewtoolkit.utils.common.div
9496
import org.ossreviewtoolkit.utils.common.gibibytes
9597
import org.ossreviewtoolkit.utils.common.searchUpwardFor
96-
import org.ossreviewtoolkit.utils.ort.OrtAuthenticator
97-
import org.ossreviewtoolkit.utils.ort.OrtProxySelector
9898
import org.ossreviewtoolkit.utils.ort.downloadText
9999
import org.ossreviewtoolkit.utils.ort.okHttpClient
100100
import org.ossreviewtoolkit.utils.ort.ortDataDirectory

plugins/package-managers/spdx-document-file/build.gradle.kts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ dependencies {
3030
implementation(jacksonLibs.jacksonDatabind)
3131
implementation(libs.okhttp)
3232
implementation(projects.downloader)
33+
implementation(projects.utils.authenticationUtils)
3334
implementation(projects.utils.commonUtils)
3435
implementation(projects.utils.ortUtils)
3536
implementation(projects.utils.spdxDocumentUtils)

plugins/package-managers/spdx-document-file/src/main/kotlin/utils/SpdxResolvedDocument.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,13 +32,13 @@ import org.ossreviewtoolkit.model.Severity
3232
import org.ossreviewtoolkit.model.createAndLogIssue
3333
import org.ossreviewtoolkit.plugins.packagemanagers.spdx.SpdxDocumentFile
3434
import org.ossreviewtoolkit.plugins.packagemanagers.spdx.SpdxDocumentFileFactory
35+
import org.ossreviewtoolkit.utils.authentication.requestPasswordAuthentication
3536
import org.ossreviewtoolkit.utils.common.collectMessages
3637
import org.ossreviewtoolkit.utils.common.safeDeleteRecursively
3738
import org.ossreviewtoolkit.utils.ort.OkHttpClientHelper
3839
import org.ossreviewtoolkit.utils.ort.addBasicAuthorization
3940
import org.ossreviewtoolkit.utils.ort.createOrtTempDir
4041
import org.ossreviewtoolkit.utils.ort.downloadFile
41-
import org.ossreviewtoolkit.utils.ort.requestPasswordAuthentication
4242
import org.ossreviewtoolkit.utils.spdxdocument.model.SpdxDocument
4343
import org.ossreviewtoolkit.utils.spdxdocument.model.SpdxExternalDocumentReference
4444
import org.ossreviewtoolkit.utils.spdxdocument.model.SpdxPackage

plugins/scanners/fossid/build.gradle.kts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ dependencies {
3030
implementation(libs.kotlinx.coroutines)
3131
implementation(libs.packageurl)
3232
implementation(projects.downloader)
33+
implementation(projects.utils.authenticationUtils)
3334
implementation(projects.utils.commonUtils)
3435
implementation(projects.utils.ortUtils)
3536
implementation(projects.utils.spdxUtils)

plugins/scanners/fossid/src/main/kotlin/FossIdUrlProvider.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,10 +24,10 @@ import java.net.PasswordAuthentication
2424

2525
import org.apache.logging.log4j.kotlin.logger
2626

27+
import org.ossreviewtoolkit.utils.authentication.requestPasswordAuthentication
2728
import org.ossreviewtoolkit.utils.common.percentEncode
2829
import org.ossreviewtoolkit.utils.common.replaceCredentialsInUri
2930
import org.ossreviewtoolkit.utils.common.toUri
30-
import org.ossreviewtoolkit.utils.ort.requestPasswordAuthentication
3131

3232
/**
3333
* An internal helper class that generates the URLs used by [FossId] to check out the repositories to be scanned.

plugins/scanners/fossid/src/test/kotlin/FossIdUrlProviderTest.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,8 @@ import io.mockk.unmockkAll
2929
import java.net.PasswordAuthentication
3030
import java.net.URI
3131

32+
import org.ossreviewtoolkit.utils.authentication.requestPasswordAuthentication
3233
import org.ossreviewtoolkit.utils.common.replaceCredentialsInUri
33-
import org.ossreviewtoolkit.utils.ort.requestPasswordAuthentication
3434

3535
class FossIdUrlProviderTest : StringSpec({
3636
afterTest {
@@ -137,7 +137,7 @@ private fun mockAuthenticator(
137137
port: Int = PORT,
138138
authentication: PasswordAuthentication? = AUTHENTICATION
139139
) {
140-
mockkStatic("org.ossreviewtoolkit.utils.ort.AuthenticationUtilsKt")
140+
mockkStatic("org.ossreviewtoolkit.utils.authentication.AuthenticationUtilsKt")
141141
every { requestPasswordAuthentication(any()) } answers {
142142
val uri = firstArg<URI>()
143143
authentication.takeIf { uri.host == host && uri.port == port && uri.scheme == "https" && uri.userInfo == null }

plugins/version-control-systems/git/build.gradle.kts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@ dependencies {
3939
implementation(libs.kotlinx.serialization.core)
4040
implementation(libs.kotlinx.serialization.xml)
4141
implementation(libs.semver4j)
42+
implementation(projects.utils.authenticationUtils)
4243
implementation(projects.utils.commonUtils)
4344
implementation(projects.utils.ortUtils)
4445

0 commit comments

Comments
 (0)