fix(detekt-rules): Correctly determine the root project#11954
Open
sschuberth wants to merge 2 commits into
Open
fix(detekt-rules): Correctly determine the root project#11954sschuberth wants to merge 2 commits into
sschuberth wants to merge 2 commits into
Conversation
sschuberth
force-pushed
the
fix-OrtPackageNaming-rule
branch
3 times, most recently
from
e5ba2af to
8517668
Compare
This did not cause violations for nested projects because the rule was skipped in that case due to `pathPattern` not being matched. Signed-off-by: Sebastian Schuberth <sebastian@doubleopen.io>
Note, according to [1] this must not be regarded as a breaking change. [1]: https://github.com/oss-review-toolkit/ort/wiki/Breaking-Change-Policy Signed-off-by: Sebastian Schuberth <sebastian@doubleopen.io>
sschuberth
force-pushed
the
fix-OrtPackageNaming-rule
branch
from
8517668 to
abda93f
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #11954 +/- ##
=========================================
Coverage 58.43% 58.43%
Complexity 1807 1807
=========================================
Files 361 361
Lines 13499 13499
Branches 1383 1383
=========================================
Hits 7888 7888
Misses 5115 5115
Partials 496 496
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This did not cause violations for nested projects because the rule was skipped in that case due to
pathPatternnot being matched.