Skip to content

Commit 3cd10d0

Browse files
Merge pull request #490 from oss-slu/245-improve-javadoc-documentation-for-servomotorhelper-class
Improve ServoMotorHelper Javadocs
2 parents 67f70db + 2624072 commit 3cd10d0

1 file changed

Lines changed: 9 additions & 5 deletions

File tree

pi4micronaut-utils/src/main/java/com/opensourcewithslu/outputdevices/ServoMotorHelper.java

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,8 @@ public ServoMotorHelper(Pwm servoMotor) {
3030
}
3131

3232
/**
33-
* Enables the servo motor by setting an initial duty cycle and frequency.
34-
* The servo motor remains disabled until this method is called.
33+
* Enables the servo motor by starting PWM output at 0% duty cycle and the
34+
* configured servo frequency.
3535
*/
3636
public void enable() {
3737
log.info("Enabling servo motor");
@@ -40,7 +40,7 @@ public void enable() {
4040
}
4141

4242
/**
43-
* Disables the servo motor, effectively stopping any ongoing PWM signal.
43+
* Disables the servo motor and stops PWM output.
4444
*/
4545
public void disable() {
4646
log.info("Disabling servo motor");
@@ -60,7 +60,11 @@ float map(float value) {
6060

6161
/**
6262
* Sets the servo motor to a specific angle.
63-
* This method calculates the necessary pulse width and duty cycle to achieve the specified angle.
63+
* <p>
64+
* The angle must be between 0 and 180 degrees. Values outside that range
65+
* are ignored and logged. This method also waits briefly after updating the
66+
* PWM signal so the servo has time to move.
67+
* </p>
6468
*
6569
* @param angle the target angle for the servo motor, between 0 and 180 degrees.
6670
*/
@@ -90,7 +94,7 @@ public void setAngle(int angle) {
9094
}
9195

9296
/**
93-
* Sets the logger for this ServoMotorHelper instance.
97+
* Sets the logger for this {@code ServoMotorHelper} instance.
9498
* This method is intended for internal testing purposes only.
9599
*
96100
* @param logger the logger to be used for logging messages.

0 commit comments

Comments
 (0)