🌱 migrate gitlab client import #4452
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Spencer Schrock <sschrock@google.com>
spencerschrock
temporarily deployed
to
gitlab
GitHub Actions
Inactive
spencerschrock
had a problem deploying
to
integration-test
GitHub Actions
Failure
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4452 +/- ##
==========================================
+ Coverage 66.80% 68.63% +1.82%
==========================================
Files 230 242 +12
Lines 16602 18031 +1429
==========================================
+ Hits 11091 12375 +1284
- Misses 4808 4848 +40
- Partials 703 808 +105 |
spencerschrock
temporarily deployed
to
integration-test
GitHub Actions
Inactive
spencerschrock
requested review from
justaugustus and
raghavkaul
and removed request for
a team
justaugustus
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
dep update
What is the current behavior?
We used the
github.com/xanzy/go-gitlabpackage.What is the new behavior (if this is a feature change)?**
The package is deprecated, in favor of the GitLab ran one:
https://gitlab.com/gitlab-org/api/client-go
Which issue(s) this PR fixes
Related to #4451
Special notes for your reviewer
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note(In particular, describe what changes users might need to make in their
application as a result of this pull request.)