Skip to content

Commit 536d836

Browse files
reid-spencerclaude
andcommitted
Remove invalid validation checks
- Stop checking metadata on epic interactions (steps don't require it) - Allow 'external' option on Context in addition to Domain Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 9e06b97 commit 536d836

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

passes/shared/src/main/scala/com/ossuminc/riddl/passes/validate/DefinitionValidation.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ object RecognizedOptions:
9797
// Icon and display options
9898
"faicon" -> OptionSpec(Seq.empty, 1, 1),
9999
// Domain/Context structural options
100-
"external" -> OptionSpec(Seq("Domain"), 0, 0),
100+
"external" -> OptionSpec(Seq("Domain", "Context"), 0, 0),
101101
"namespace" -> OptionSpec(Seq("Domain", "Context"), 1, 1),
102102
"package" -> OptionSpec(Seq("Domain", "Context"), 1, 1)
103103
)

passes/shared/src/main/scala/com/ossuminc/riddl/passes/validate/ValidationPass.scala

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -161,8 +161,8 @@ case class ValidationPass(
161161
validateContext(c, parentsAsSeq)
162162
case d: Domain =>
163163
validateDomain(d, parentsAsSeq)
164-
case s: Epic =>
165-
validateEpic(s, parentsAsSeq)
164+
case e: Epic =>
165+
validateEpic(e, parentsAsSeq)
166166
case uc: UseCase =>
167167
validateUseCase(uc, parentsAsSeq)
168168
case grp: Group =>
@@ -1236,7 +1236,7 @@ case class ValidationPass(
12361236
// FIXME: This should be used
12371237
private def validateInteraction(interaction: Interaction, parents: Parents): Unit = {
12381238
val useCase = parents.head
1239-
checkMetadata(useCase.identify, interaction, interaction.loc)
1239+
// checkMetadata(useCase.identify, interaction, interaction.loc)
12401240
interaction match {
12411241
case SelfInteraction(_, from, _, _) =>
12421242
checkRef[Definition](from, parents)

0 commit comments

Comments
 (0)