Skip to content

Commit fab9a58

Browse files
respencer-nclclaude
andcommitted
Update docs for v1.2.5 release
- Update version references in CLAUDE.md and README.md - Document v1.2.5 changes in NOTEBOOK.md (CI fixes, git detection) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
1 parent fb38b19 commit fab9a58

3 files changed

Lines changed: 40 additions & 9 deletions

File tree

CLAUDE.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ SBT plugin providing build infrastructure and configuration helpers for Ossum
1414
Inc. projects. Defines declarative project types and configuration options
1515
used across all Scala projects in the organization.
1616

17-
**Current version: 1.2.4** (updated Jan 2026)
17+
**Current version: 1.2.5** (updated Jan 2026)
1818

1919
## Project Types Provided
2020

@@ -135,7 +135,7 @@ sbt scalafmt
135135
All Scala projects in ossuminc use this plugin. Add to `project/plugins.sbt`:
136136

137137
```scala
138-
addSbtPlugin("com.ossuminc" % "sbt-ossuminc" % "1.2.4")
138+
addSbtPlugin("com.ossuminc" % "sbt-ossuminc" % "1.2.5")
139139
```
140140

141141
### Example CrossModule Definition

NOTEBOOK.md

Lines changed: 37 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2,14 +2,45 @@
22

33
## Current Status
44

5-
**Version 1.2.4 released.** Added Akka Insights (withInsights) and Kubernetes
6-
management (withManagementKubernetes) support to the Akka helper.
7-
8-
Note: CI scripted tests failing due to environment issues unrelated to code changes.
9-
Manual `sbt publish` used for release.
5+
**Version 1.2.5 released.** Fixed CI scripted tests and AKKA_REPO_TOKEN
6+
propagation. All 16 scripted tests now pass in CI.
107

118
## Work Completed (Recent)
129

10+
### Session Jan 28-29, 2026 - v1.2.5 Released (CI Fixes)
11+
12+
**Released:** v1.2.5 to GitHub Packages
13+
14+
**Root Cause Analysis:**
15+
The scripted tests had been failing since PR #8 "Use native git instead of
16+
JGit for worktree support". Native git fails hard in non-git directories,
17+
while JGit was more lenient. Scripted tests run in temp directories that
18+
aren't git repositories.
19+
20+
**Bug Fixes:**
21+
1. **Git/DynamicVersioning helpers now detect git repos** - Added `isGitRepo`
22+
check that walks up directory tree looking for `.git`. Only enables native
23+
git (`useReadableConsoleGit`) if actually in a git repo. Falls back to JGit
24+
for non-git directories (scripted tests).
25+
26+
2. **AKKA_REPO_TOKEN propagation to scripted tests** - The `scriptedLaunchOpts`
27+
now passes `AKKA_REPO_TOKEN` as system property `-Dakka.repo.token=...`.
28+
The Akka helper checks both `sys.props` and `sys.env` for the token.
29+
30+
3. **Modules now apply Resolvers** - `Module()` was missing the Resolvers
31+
configuration, breaking dependency resolution for Akka dependencies.
32+
33+
**Improvements:**
34+
- Updated scripted test build.sbt files to use modern PascalCase `With.*`
35+
syntax (BuildInfo, Scala3, Riddl) instead of deprecated lowercase versions.
36+
37+
**Technical Notes:**
38+
- The `isGitRepo` function is duplicated in both Git.scala and
39+
DynamicVersioning.scala because the project/ directory uses symlinks to
40+
the source files, and DynamicVersioning.scala is linked while Git.scala
41+
is not. Sharing the function would require adding another symlink.
42+
- CI now passes all 16 scripted tests.
43+
1344
### Session Jan 27, 2026 - Documentation Updates
1445

1546
Improved documentation for With.Akka helper to reduce confusion for users:
@@ -163,7 +194,7 @@ Run scripted tests on every PR. Skip Akka test in CI (requires credentials).
163194

164195
## Test Coverage Status
165196

166-
### Current Test Results (Jan 17, 2026)
197+
### Current Test Results (Jan 29, 2026)
167198

168199
| Test Scenario | Purpose | Status |
169200
|----------------|-------------------------------|---------------------------|

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ In your `project/plugins.sbt` file, add the GitHub Packages resolver and the plu
8282
// GitHub Packages resolver for sbt-ossuminc
8383
resolvers += "GitHub Packages" at "https://maven.pkg.github.com/ossuminc/sbt-ossuminc"
8484

85-
addSbtPlugin("com.ossuminc" % "sbt-ossuminc" % "1.2.4")
85+
addSbtPlugin("com.ossuminc" % "sbt-ossuminc" % "1.2.5")
8686
```
8787

8888
### ~/sbt/1.0/github.sbt

0 commit comments

Comments
 (0)