Skip to content

Commit bb49743

Browse files
committed
Update based on review comments
1 parent 31b4a94 commit bb49743

File tree

4 files changed

+3
-48
lines changed

4 files changed

+3
-48
lines changed

api/fma/v1alpha1/launcherpoolpolicy_types.go

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -191,12 +191,6 @@ type CountForLauncher struct {
191191
// LauncherCount is the total number of launcher pods to maintain.
192192
// +required
193193
LauncherCount int32 `json:"launcherCount"`
194-
195-
// Apply this count only to accelerators on the node that
196-
// match this selector. When omitted, the count applies to the node regardless
197-
// of accelerator sets (convenient for homogeneous clusters).
198-
// +optional
199-
AcceleratorSelector *AcceleratorSelector `json:"acceleratorSelector,omitempty"`
200194
}
201195

202196
type LauncherPoolPolicyStatus struct {

api/fma/v1alpha1/zz_generated.deepcopy.go

Lines changed: 1 addition & 8 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

config/crd/fma.llm-d.ai_launcherpoolpolicies.yaml

Lines changed: 0 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -54,29 +54,6 @@ spec:
5454
matching accelerator (if omitted, apply regardless of accelerator sets).
5555
items:
5656
properties:
57-
acceleratorSelector:
58-
description: |-
59-
Apply this count only to accelerators on the node that
60-
match this selector. When omitted, the count applies to the node regardless
61-
of accelerator sets (convenient for homogeneous clusters).
62-
properties:
63-
count:
64-
description: Count specifies required number of accelerators
65-
format: int32
66-
type: integer
67-
memory:
68-
anyOf:
69-
- type: integer
70-
- type: string
71-
description: Memory specifies accelerator memory size
72-
requirement
73-
pattern: ^(\+|-)?(([0-9]+(\.[0-9]*)?)|(\.[0-9]+))(([KMGTPE]i)|[numkMGTPE]|([eE](\+|-)?(([0-9]+(\.[0-9]*)?)|(\.[0-9]+))))?$
74-
x-kubernetes-int-or-string: true
75-
type:
76-
description: Type specifies accelerator type (e.g.,
77-
nvidia.com/gpu)
78-
type: string
79-
type: object
8057
launcherConfigName:
8158
description: LauncherConfigName is the name of the LauncherConfig
8259
this policy applies to.

pkg/generated/applyconfiguration/fma/v1alpha1/countforlauncher.go

Lines changed: 2 additions & 11 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)