Fix wrong comparison of floats in function compareValues

ostafen · ostafen · commit da18a9235e5e · 2022-03-19T17:16:01.000+01:00
diff --git a/criteria.go b/criteria.go
@@ -2,6 +2,7 @@ package clover
 
 import (
 	"encoding/json"
+	"math/big"
 	"reflect"
 	"strings"
 )
@@ -75,7 +76,7 @@ func compareValues(v1 interface{}, v2 interface{}) (int, bool) {
 	if isFloat {
 		v2Float, isFloat := v2.(float64)
 		if isFloat {
-			return int(v1Float - v2Float), true
+			return big.NewFloat(v1Float).Cmp(big.NewFloat(v2Float)), true
 		}
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -2,6 +2,7 @@ package clover`
`2`	`2`
`3`	`3`	`import (`
`4`	`4`	`"encoding/json"`
	`5`	`+ "math/big"`
`5`	`6`	`"reflect"`
`6`	`7`	`"strings"`
`7`	`8`	`)`
`@@ -75,7 +76,7 @@ func compareValues(v1 interface{}, v2 interface{}) (int, bool) {`
`75`	`76`	`if isFloat {`
`76`	`77`	`v2Float, isFloat := v2.(float64)`
`77`	`78`	`if isFloat {`
`78`		`- return int(v1Float - v2Float), true`
	`79`	`+ return big.NewFloat(v1Float).Cmp(big.NewFloat(v2Float)), true`
`79`	`80`	`}`
`80`	`81`	`}`
`81`	`82`