avr-gdb: upgrade to GDB 15.2

This makes our formula match these other cross-built GDBs in homebrew-core:

- [riscv64-elf-gdb](https://github.com/Homebrew/homebrew-core/blob/master/Formula/r/riscv64-elf-gdb.rb)
- [arm-none-eabi-gdb](https://github.com/Homebrew/homebrew-core/blob/master/Formula/a/arm-none-eabi-gdb.rb)
- [x86_64-elf-gdb](https://github.com/Homebrew/homebrew-core/blob/master/Formula/x/x86_64-elf-gdb.rb)
- [i386-elf-gdb](https://github.com/Homebrew/homebrew-core/blob/master/Formula/i/i386-elf-gdb.rb)

Changes from our previous formula:

- GDB now requires GMP (as of 11.1, [commit](https://sourceware.org/git/?p=binutils-gdb.git;a=commitdiff;h=1b4ac058f7daeb9bac9ab0e63a7e73535208dfef)) and MPFR (as of 14, [commit](https://sourceware.org/git/?p=binutils-gdb.git;a=commit;f=configure.ac;h=991180627851801f1999d1ebbc0e569a17e47c74))

- remove `--prefix=#{prefix}` + `--disable-debug` + `--disable-dependency-tracking`. These have been added to a reusable `std_configure_args` (as documented here in the [Formula Cookbook](https://github.com/Homebrew/brew/blob/c81b2e43855f0a9bc86339bda73c3e073b061641/docs/Formula-Cookbook.md#std_configure_args)).

- remove `--disable-install-libbfd`. In the [bfd configure script](https://sourceware.org/git/?p=binutils-gdb.git;a=blob;f=bfd/acinclude.m4;h=0ba7957760dfd13a9a97c2c4fbca30f231393c28;hb=HEAD#l62), this looks to be disabled if `host != target` (which is true for us).

- remove `--disable-install-libiberty`. In the [libiberty configure script](https://sourceware.org/git/?p=binutils-gdb.git;a=blob;f=libiberty/configure.ac;h=c27e08e14288ed489e45e23b0c83e009721b47ba;hb=HEAD#l148), this looks to already be disabled by default.

I think we're also avoiding installing libiberty and libbfd by using `make install-gdb` instead of `make install`.

- remove `--disable-nls` + `--disable-libssp`. I think these flags got copied over from our GCC formulae, but they don't actaully apply to GDB (docs for [GCC configure options](https://gcc.gnu.org/install/configure.html) versus [GDB configure options](https://sourceware.org/gdb/current/onlinedocs/gdb.html/Configure-Options.html)). Same goes for our `avr-binutils` formula dependency.

Addresses #343, since the newer GDB version has addressed the Clang errors outlined in the issue.

**Side note about installation directories**

I wanted to know if we actually needed to customize all those installation directories in the configure script flags, so I installed to a custom `DESTDIR` and checked out the files. Here's what I found (the [GNU Makefile Conventions docs](https://www.gnu.org/prep/standards/html_node/Directory-Variables.html) were helpful here):

GDB installs executables into `bindir`, headers into `includedir` (e.g. for GDB's [JIT interface](https://sourceware.org/gdb/download/onlinedocs/gdb.html/Writing-JIT-Debug-Info-Readers.html#Writing-JIT-Debug-Info-Readers)), data files into `datadir` ([Python helper functions](https://sourceware.org/gdb/download/onlinedocs/gdb.html/Python.html#Python), the [syscall name database](https://sourceware.org/gdb/download/onlinedocs/gdb.html/Set-Catchpoints.html#Set-Catchpoints)), manpages in `mandir`, Info files in `infodir`, and locale files in `localedir`.

Some installed files have a disambiguating prefix of the target architecture (e.g. `avr-gdb`), but most files don't, so they would overwrite files from an existing installation of GDB. Therefore, we specify a disambiguating subdirectory for all the installation directories, _except_: `bindir` (the executables already have the appropriate prefix) and `libdir` (`install-gdb` doesn't install anything here).

`mandir` needs to be modified, not because the installed manpage files don't have the appropriate prefix (they do), or because they get installed to `#{prefix}/man` instead of `#{prefix}/share/man` (like the [Formula Cookbook cautions against](https://github.com/Homebrew/brew/blob/c81b2e43855f0a9bc86339bda73c3e073b061641/docs/Formula-Cookbook.md#manuals)), but because we're customizing `datarootdir`, which causes `make` to install the files to `#{prefix}/share/#{target}/man` instead of `#{prefix}/share/man` like they should go. So we need to "undo" the change we made to `datarootdir` here (as an alternative, I think we could have left `datarootdir` and `mandir` alone, and instead customized `datadir` / `includedir` / `localedir` / `infodir`).

Closes #352.

Signed-off-by: osxCrossTestBot <[email protected]>

Author: reillylm

Formula/avr-gdb.rb

@@ -1,10 +1,15 @@
 class AvrGdb < Formula
-  desc "GDB lets you to see what is going on inside a program while it executes"
+  desc "GNU debugger for AVR 8-bit and 32-bit Microcontrollers"
   homepage "https://www.gnu.org/software/gdb/"
-
-  url "https://ftp.gnu.org/gnu/gdb/gdb-10.1.tar.xz"
-  mirror "https://ftpmirror.gnu.org/gdb/gdb-10.1.tar.xz"
-  sha256 "f82f1eceeec14a3afa2de8d9b0d3c91d5a3820e23e0a01bbb70ef9f0276b62c0"
+  url "https://ftp.gnu.org/gnu/gdb/gdb-15.2.tar.xz"
+  mirror "https://ftpmirror.gnu.org/gdb/gdb-15.2.tar.xz"
+  sha256 "83350ccd35b5b5a0cba6b334c41294ea968158c573940904f00b92f76345314d"
+  license "GPL-3.0-or-later"
+  head "https://sourceware.org/git/binutils-gdb.git", branch: "master"
+
+  livecheck do
+    formula "gdb"
+  end
 
   bottle do
     root_url "https://github.com/osx-cross/homebrew-avr/releases/download/avr-gdb-10.1"
@@ -14,60 +19,49 @@ class AvrGdb < Formula
     sha256 big_sur:  "8768ff3f7ef4c90864a18b1dc15817adc251304b4e74ef3ff6ac3b2595e9f6af"
   end
 
-  depends_on "osx-cross/avr/avr-binutils"
-
-  depends_on "[email protected]"
+  depends_on "avr-gcc@14" => :test
+  depends_on "gmp"
+  depends_on "mpfr"
+  depends_on "[email protected]"
+  depends_on "xz" # required for lzma support
 
   uses_from_macos "expat"
   uses_from_macos "ncurses"
+  uses_from_macos "zlib"
 
-  on_ventura :or_newer do
+  on_system :linux, macos: :ventura_or_newer do
     depends_on "texinfo" => :build
   end
 
-  # Fix symbol format elf32-avr unknown in gdb
-  patch do
-    url "https://raw.githubusercontent.com/osx-cross/homebrew-avr/18d50ba2a168a3b90a25c96e4bc4c053df77d7dc/Patch/avr-binutils-elf-bfd-gdb-fix.patch"
-    sha256 "7954f85d2e0f628c261bdd486df8e1a229bc5bacc6ea4a0da003913cb96543f6"
-  end
-
   def install
+    target = "avr"
     args = %W[
-      --target=avr
-      --prefix=#{prefix}
-
-      --disable-debug
-      --disable-dependency-tracking
-
+      --target=#{target}
+      --datarootdir=#{share}/#{target}
+      --includedir=#{include}/#{target}
+      --infodir=#{info}/#{target}
+      --mandir=#{man}
+      --with-lzma
+      --with-python=#{Formula["[email protected]"].opt_bin}/python3.12
+      --with-system-zlib
       --disable-binutils
-
-      --disable-nls
-      --disable-libssp
-      --disable-install-libbfd
-      --disable-install-libiberty
-
-      --with-python=#{Formula["[email protected]"].opt_bin}/python3.9
     ]
 
     mkdir "build" do
-      system "../configure", *args
+      system "../configure", *args, *std_configure_args
+      ENV.deparallelize # Error: common/version.c-stamp.tmp: No such file or directory
       system "make"
 
       # Don't install bfd or opcodes, as they are provided by binutils
       system "make", "install-gdb"
     end
   end
 
-  def caveats
-    <<~EOS
-      gdb requires special privileges to access Mach ports.
-      You will need to codesign the binary. For instructions, see:
-
-        https://sourceware.org/gdb/wiki/BuildingOnDarwin
-
-      On 10.12 (Sierra) or later with SIP, you need to run this:
+  test do
+    (testpath/"test.c").write "void _start(void) {}"
+    system "#{Formula["avr-gcc@14"].bin}/avr-gcc", "-g", "-nostdlib", "test.c"
 
-        echo "set startup-with-shell off" >> ~/.gdbinit
-    EOS
+    output = shell_output("#{bin}/avr-gdb -batch -ex 'info address _start' a.out")
+    assert_match "Symbol \"_start\" is a function at address 0x", output
   end
 end