feat(vscode): show subfolders in Move/Duplicate into Vault picker

transferToVault() now enumerates subfolders via tracker.listFolders()
and includes descendants of mounted folders in the QuickPick, falling
back to mount roots only when the call fails.

Assisted-by: Claude

Author: otaviof

packages/vscode/package.json

@@ -2,7 +2,7 @@
   "name": "obsidian-vfs",
   "displayName": "Obsidian VFS",
   "description": "Browse, search, and edit your Obsidian vault directly in VSCode via a virtual file system (obs://)",
-  "version": "1.2.0",
+  "version": "1.2.1",
   "private": true,
   "publisher": "otaviof",
   "engines": {

packages/vscode/src/commands.test.ts

@@ -834,7 +834,9 @@ function describeVaultTransferCommand(
 
       vi.mocked(vscode.window.showQuickPick).mockResolvedValueOnce(undefined);
 
-      const tracker = mockLocalIndexTracker();
+      const tracker = mockLocalIndexTracker({
+        listFolders: vi.fn().mockResolvedValue({ ok: true, value: [] }),
+      });
       const { handler } = invokeCommandWithUri(COMMAND[commandKey], tracker);
       await handler();
 
@@ -858,7 +860,9 @@ function describeVaultTransferCommand(
       });
       vi.mocked(vscode.window.showInputBox).mockResolvedValueOnce(undefined);
 
-      const tracker = mockLocalIndexTracker();
+      const tracker = mockLocalIndexTracker({
+        listFolders: vi.fn().mockResolvedValue({ ok: true, value: [] }),
+      });
       const { handler } = invokeCommandWithUri(COMMAND[commandKey], tracker);
       await handler();
 
@@ -883,6 +887,7 @@ function describeVaultTransferCommand(
       vi.mocked(vscode.window.showInputBox).mockResolvedValueOnce("meeting.md");
 
       const tracker = mockLocalIndexTracker({
+        listFolders: vi.fn().mockResolvedValue({ ok: true, value: [] }),
         stat: vi.fn().mockResolvedValue({
           ok: true,
           value: { type: "file", mtime: 0, ctime: 0, size: 0 },
@@ -914,6 +919,7 @@ function describeVaultTransferCommand(
       vi.mocked(vscode.window.showInputBox).mockResolvedValueOnce("file.md");
 
       const tracker = mockLocalIndexTracker({
+        listFolders: vi.fn().mockResolvedValue({ ok: true, value: [] }),
         stat: vi.fn().mockResolvedValue({
           ok: false,
           error: { code: "FILE_NOT_FOUND", message: "not found" },
@@ -951,6 +957,7 @@ function describeVaultTransferCommand(
       vi.mocked(vscode.window.showInputBox).mockResolvedValueOnce("file.md");
 
       const tracker = mockLocalIndexTracker({
+        listFolders: vi.fn().mockResolvedValue({ ok: true, value: [] }),
         stat: vi.fn().mockResolvedValue({
           ok: false,
           error: { code: "FILE_NOT_FOUND", message: "not found" },
@@ -987,6 +994,7 @@ function describeVaultTransferCommand(
       vi.mocked(vscode.window.showInformationMessage).mockResolvedValueOnce(undefined);
 
       const tracker = mockLocalIndexTracker({
+        listFolders: vi.fn().mockResolvedValue({ ok: true, value: [] }),
         stat: vi.fn().mockResolvedValue({
           ok: false,
           error: { code: "FILE_NOT_FOUND", message: "not found" },
@@ -1038,6 +1046,7 @@ function describeVaultTransferCommand(
       );
 
       const tracker = mockLocalIndexTracker({
+        listFolders: vi.fn().mockResolvedValue({ ok: true, value: [] }),
         stat: vi.fn().mockResolvedValue({
           ok: false,
           error: { code: "FILE_NOT_FOUND", message: "not found" },
@@ -1072,6 +1081,7 @@ function describeVaultTransferCommand(
       vi.mocked(vscode.window.showInformationMessage).mockResolvedValueOnce(undefined);
 
       const tracker = mockLocalIndexTracker({
+        listFolders: vi.fn().mockResolvedValue({ ok: true, value: [] }),
         stat: vi.fn().mockResolvedValue({
           ok: false,
           error: { code: "FILE_NOT_FOUND", message: "not found" },
@@ -1106,16 +1116,85 @@ function describeVaultTransferCommand(
 
       vi.mocked(vscode.window.showQuickPick).mockResolvedValueOnce(undefined);
 
-      const tracker = mockLocalIndexTracker();
+      const tracker = mockLocalIndexTracker({
+        listFolders: vi.fn().mockResolvedValue({ ok: true, value: [] }),
+      });
       const { handler } = invokeCommandWithUri(COMMAND[commandKey], tracker);
       await handler();
 
       expect(vscode.window.showQuickPick).toHaveBeenCalledWith(
         [
-          { label: "30-resources", description: "30-resources" },
           { label: "active", description: "10-projects/active" },
+          { label: "30-resources", description: "30-resources" },
         ],
-        expect.objectContaining({ placeHolder: "Select destination folder" }),
+        expect.objectContaining({
+          placeHolder: "Select destination folder",
+          matchOnDescription: true,
+        }),
+      );
+    });
+
+    it("includes subfolders in QuickPick when listFolders succeeds", async () => {
+      mockReadAutoMount.mockReturnValue(["30-resources"]);
+      setupConfigMock();
+
+      Object.defineProperty(vscode.window, "activeTextEditor", {
+        value: { document: { uri: { scheme: "file", fsPath: "/project/file.md" } } },
+        writable: true,
+        configurable: true,
+      });
+
+      vi.mocked(vscode.window.showQuickPick).mockResolvedValueOnce(undefined);
+
+      const tracker = mockLocalIndexTracker({
+        listFolders: vi.fn().mockResolvedValue({
+          ok: true,
+          value: ["30-resources", "30-resources/books", "30-resources/papers", "10-projects"],
+        }),
+      });
+      const { handler } = invokeCommandWithUri(COMMAND[commandKey], tracker);
+      await handler();
+
+      expect(vscode.window.showQuickPick).toHaveBeenCalledWith(
+        [
+          { label: "30-resources", description: "30-resources" },
+          { label: "books", description: "30-resources/books" },
+          { label: "papers", description: "30-resources/papers" },
+        ],
+        expect.objectContaining({
+          placeHolder: "Select destination folder",
+          matchOnDescription: true,
+        }),
+      );
+    });
+
+    it("falls back to mounted folders when listFolders fails", async () => {
+      mockReadAutoMount.mockReturnValue(["30-resources"]);
+      setupConfigMock();
+
+      Object.defineProperty(vscode.window, "activeTextEditor", {
+        value: { document: { uri: { scheme: "file", fsPath: "/project/file.md" } } },
+        writable: true,
+        configurable: true,
+      });
+
+      vi.mocked(vscode.window.showQuickPick).mockResolvedValueOnce(undefined);
+
+      const tracker = mockLocalIndexTracker({
+        listFolders: vi.fn().mockResolvedValue({
+          ok: false,
+          error: { code: "CLI_ERROR", message: "failed" },
+        }),
+      });
+      const { handler } = invokeCommandWithUri(COMMAND[commandKey], tracker);
+      await handler();
+
+      expect(vscode.window.showQuickPick).toHaveBeenCalledWith(
+        [{ label: "30-resources", description: "30-resources" }],
+        expect.objectContaining({
+          placeHolder: "Select destination folder",
+          matchOnDescription: true,
+        }),
       );
     });
   });

packages/vscode/src/commands.ts

@@ -201,20 +201,28 @@ async function transferToVault(
     return;
   }
 
-  const folders = mountedFolders();
-  if (folders.length === 0) {
+  const mounts = mountedFolders();
+  if (mounts.length === 0) {
     await vscode.window.showInformationMessage(
       "No mounted folders available. Mount a folder first.",
     );
     return;
   }
 
-  const items = folders.map((f) => ({
+  let candidates = mounts;
+  const foldersResult = await tracker.listFolders(readDepthLimit());
+  if (foldersResult.ok) {
+    const descendants = foldersResult.value.filter((f) => mounts.some((m) => f.startsWith(`${m}/`)));
+    candidates = [...mounts, ...descendants].sort();
+  }
+
+  const items = candidates.map((f) => ({
     label: f.split("/").pop()!,
     description: f,
   }));
   const picked = await vscode.window.showQuickPick(items, {
     placeHolder: "Select destination folder",
+    matchOnDescription: true,
   });
   if (!picked) return;