Skip to content

Commit ca13e3f

Browse files
committed
refactor(test): optimize VSCode test suite
Extract invokeCommand helper in commands.test.ts (-157 lines), add COMMAND constant to types.ts to eliminate repeated string literals, remove 3 low-value status-bar tests, add git detection unit tests (9), FSP dispose test, and copyPath scheme guard test. Group syncFilesExclude 18 tests into 7 sub-describes for navigability. Rename mockTracker to mockLocalIndexTracker for clarity. Assisted-by: Claude
1 parent 34d904f commit ca13e3f

9 files changed

Lines changed: 702 additions & 725 deletions

packages/vscode/src/commands.test.ts

Lines changed: 117 additions & 274 deletions
Large diffs are not rendered by default.

packages/vscode/src/commands.ts

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import * as vscode from "vscode";
22
import type { LocalIndexTracker } from "@obsidian-vfs/core";
33
import { buildObsUri } from "@obsidian-vfs/core";
44

5-
import { CONFIG_KEY, CONFIG_SECTION } from "./types.js";
5+
import { COMMAND, CONFIG_KEY, CONFIG_SECTION } from "./types.js";
66
import { SCHEME, toFileUri, toVaultPath, toVaultPathFromFile } from "./uri-adapter.js";
77
import type { VaultTreeDataProvider } from "./vault-tree-provider.js";
88
import { readAutoMount } from "./vault-tree-provider.js";
@@ -163,15 +163,15 @@ export function registerCommands(
163163
outputChannel: vscode.OutputChannel,
164164
): void {
165165
context.subscriptions.push(
166-
vscode.commands.registerCommand("obsidianVFS.mount", () => mountCommand(tracker, treeProvider)),
167-
vscode.commands.registerCommand("obsidianVFS.mountNote", () =>
166+
vscode.commands.registerCommand(COMMAND.mount, () => mountCommand(tracker, treeProvider)),
167+
vscode.commands.registerCommand(COMMAND.mountNote, () =>
168168
mountNoteCommand(tracker, treeProvider),
169169
),
170-
vscode.commands.registerCommand("obsidianVFS.unmount", () => unmountCommand(treeProvider)),
171-
vscode.commands.registerCommand("obsidianVFS.openInObsidian", () =>
170+
vscode.commands.registerCommand(COMMAND.unmount, () => unmountCommand(treeProvider)),
171+
vscode.commands.registerCommand(COMMAND.openInObsidian, () =>
172172
openInObsidianCommand(tracker, outputChannel),
173173
),
174-
vscode.commands.registerCommand("obsidianVFS.searchNotes", () => searchNotesCommand(tracker)),
175-
vscode.commands.registerCommand("obsidianVFS.copyPath", () => copyPathCommand(tracker)),
174+
vscode.commands.registerCommand(COMMAND.searchNotes, () => searchNotesCommand(tracker)),
175+
vscode.commands.registerCommand(COMMAND.copyPath, () => copyPathCommand(tracker)),
176176
);
177177
}

0 commit comments

Comments
 (0)