Remove old protocols in favor of HTTP endpoints

[ramon-bernardo]

The server currently maintains several legacy protocol impls (Protocol old, login and status) that are no longer required for latest client. These protocols add unnecessary maintenance overhead and complexity to the net layer.

This issue proposes removing these outdated protocol handlers and transitioning their responsibilities to HTTP-based endpoints.

• Protocol old. refactor(protocol): remove legacy ProtocolOld impl #5037
• Protocol login. refactor(protocol): remove legacy ProtocolLogin impl #5038
• Protocol status. refactor(protocol): drop ProtocolStatus in favor of HTTP-based serverinfo endpoint #5040 after HTTP server info handler #4964

[Zbizu]

As both otcv8 and otcr are capable of login over http, and most servers provide their own clients to play (often with custom sprites), the ipchangers became a thing of the past. This means that the chance of old clients attempting to access the legacy login service becomes more and more unlikely.

Only thing I disagree with is removing protocolstatus because you are forcing all server lists to modify their code just to support one more engine.

[ramon-bernardo]

@Zbizu i don’t quite remember if main OT list supports HTTP requests, although i recall reading something about it on the otland. We can confirm that, and if it turns out to be necessary, we’ll keep the status protocol.

The main idea for now, is just to move these changes from concept to a PR for review 😃

[Zbizu]

@Zbizu i don’t quite remember if main OT list supports HTTP requests, although i recall reading something about it on the otland. We can confirm that, and if it turns out to be necessary, we’ll keep the status protocol.

The main idea for now, is just to move these changes from concept to a PR for review 😃

otservlist.org is using the "info" (xml) protocol
otservers.online is using the tcp protocolstatus for character profiles, see https://otservers.online/players/110:1:zbizu