New lint missing_mut_constraint (#11)

* feat: new lint missing_mut_constraint

* chore: cargo fmt

* tests: Use workspace deps for anchor in test programs

* Update lints/missing_mut_constraint/Cargo.toml

Co-authored-by: Jamie Hill-Daniel <134328753+jamie-osec@users.noreply.github.com>

* refactor: move account_name_from_place_or_rvalue into MirAnalyzer

* chore: Use `cargo-install` action to install package (#14)

* chore: cargo fmt

---------

Co-authored-by: Jamie Hill-Daniel <134328753+jamie-osec@users.noreply.github.com>

Author: meumar-osec

Cargo.lock

@@ -28,6 +28,7 @@ cargo install cargo-dylint dylint-link
 | [`direct_lamport_cpi_dos`](lints/direct_lamport_cpi_dos) |
 | [`overconstrained_seed_account`](lints/overconstrained_seed_account) |
 | [`unsafe_pyth_price_account`](lints/unsafe_pyth_price_account) |
+| [`missing_mut_constraint`](lints/missing_mut_constraint) |
 
 ## Usage
 
@@ -68,4 +69,5 @@ cargo test ata_should_use_init_if_needed_tests
 cargo test direct_lamport_cpi_dos_tests
 cargo test overconstrained_seed_account_tests
 cargo test unsafe_pyth_price_account_tests
+cargo test missing_mut_constraint_tests
 ```

README.md

@@ -1,7 +1,7 @@
 use clippy_utils::{source::HasSession, ty::is_type_diagnostic_item};
 use rustc_middle::{
-    mir::{HasLocalDecls, Local},
-    ty::TyKind,
+    mir::{HasLocalDecls, Local, Place, Rvalue},
+    ty::{Mutability, TyKind},
 };
 use rustc_span::source_map::Spanned;
 use rustc_span::sym;
@@ -183,6 +183,43 @@ impl<'cx, 'tcx> MirAnalyzer<'cx, 'tcx> {
         );
         account_name_and_locals.first().cloned()
     }
+
+    /// Extracts the account name from a place or rvalue
+    pub fn account_name_from_place_or_rvalue(
+        &self,
+        place: &Place<'_>,
+        rvalue: &Rvalue<'_>,
+    ) -> Option<String> {
+        let base_local = place.local;
+        let resolved = self.resolve_to_original_local(base_local, &mut HashSet::new());
+        if let Some(acc) = self.extract_account_name_from_local(&resolved, true) {
+            let name = acc
+                .account_name
+                .split('.')
+                .next()
+                .unwrap_or(&acc.account_name)
+                .to_string();
+            return Some(name);
+        }
+
+        if let Rvalue::Ref(_, borrow_kind, ref_place) = rvalue
+            && borrow_kind.mutability() == Mutability::Mut
+        {
+            let base = ref_place.local;
+            let resolved = self.resolve_to_original_local(base, &mut HashSet::new());
+            if let Some(acc) = self.extract_account_name_from_local(&resolved, true) {
+                let name = acc
+                    .account_name
+                    .split('.')
+                    .next()
+                    .unwrap_or(&acc.account_name)
+                    .to_string();
+                return Some(name);
+            }
+        }
+
+        None
+    }
 }
 
 fn push_account_name_and_return(

anchor-lints-utils/src/mir_analyzer/account_extraction.rs

@@ -9,5 +9,5 @@ workspace = "../../../../tests"
 crate-type = ["cdylib"]
 
 [dependencies]
-anchor-lang = { git = "https://github.com/jamie-osec/anchor", rev = "939b843" }
-anchor-spl = { git = "https://github.com/jamie-osec/anchor", rev = "939b843" }
+anchor-lang = { workspace = true }
+anchor-spl = { workspace = true }

lints/arbitrary_cpi_call/tests/test_program/Cargo.toml

@@ -9,6 +9,6 @@ workspace = "../../../../tests"
 crate-type = ["cdylib"]
 
 [dependencies]
-anchor-lang = { git = "https://github.com/jamie-osec/anchor", rev = "939b843", features = ["init-if-needed"] }
-anchor-spl = { git = "https://github.com/jamie-osec/anchor", rev = "939b843" }
+anchor-lang = { workspace = true, features = ["init-if-needed"] }
+anchor-spl = { workspace = true }
 

lints/ata_should_use_init_if_needed/tests/test_program/Cargo.toml

@@ -9,6 +9,6 @@ workspace = "../../../../tests"
 crate-type = ["cdylib"]
 
 [dependencies]
-anchor-lang = { git = "https://github.com/jamie-osec/anchor", rev = "939b843" }
-anchor-spl = { git = "https://github.com/jamie-osec/anchor", rev = "939b843" }
+anchor-lang = { workspace = true }
+anchor-spl = { workspace = true }
 

lints/cpi_no_result/tests/test_program/Cargo.toml

@@ -9,6 +9,6 @@ workspace = "../../../../tests"
 crate-type = ["cdylib"]
 
 [dependencies]
-anchor-lang = { git = "https://github.com/jamie-osec/anchor", rev = "939b843" }
-anchor-spl = { git = "https://github.com/jamie-osec/anchor", rev = "939b843" }
+anchor-lang = { workspace = true }
+anchor-spl = { workspace = true }
 

lints/direct_lamport_cpi_dos/tests/test_program/Cargo.toml

@@ -9,5 +9,5 @@ workspace = "../../../../tests"
 crate-type = ["cdylib"]
 
 [dependencies]
-anchor-lang = { git = "https://github.com/jamie-osec/anchor", rev = "939b843" }
-anchor-spl = { git = "https://github.com/jamie-osec/anchor", rev = "939b843" }
+anchor-lang = { workspace = true }
+anchor-spl = { workspace = true }

lints/duplicate_mutable_accounts/tests/test_program/Cargo.toml

@@ -9,7 +9,7 @@ workspace = "../../../../tests"
 crate-type = ["cdylib"]
 
 [dependencies]
-anchor-lang = { git = "https://github.com/jamie-osec/anchor.git", branch = "anchor-lint" }
-anchor-spl = { git = "https://github.com/jamie-osec/anchor.git", branch = "anchor-lint" }
+anchor-lang = { workspace = true }
+anchor-spl = { workspace = true }
 
 

lints/missing_account_field_init/tests/test_program/Cargo.toml

@@ -9,4 +9,4 @@ workspace = "../../../../tests"
 crate-type = ["cdylib"]
 
 [dependencies]
-anchor-lang = { git = "https://github.com/jamie-osec/anchor", rev = "939b843" }
+anchor-lang = { workspace = true }