lang: Reduce cloning in realloc constraint when shrinking (#4642)

* lang: Reduce cloning in `realloc` constraint when shrinking

* tests: Remove the unused Cargo profile in `realloc`

* Update CHANGELOG

---------

Co-authored-by: Jamie Hill-Daniel <134328753+jamie-osec@users.noreply.github.com>

Author: acheroncrypto

CHANGELOG.md

@@ -51,6 +51,7 @@ The minor version will be incremented upon a breaking change and the patch versi
 - ts: Validate instruction args in `BorshInstructionCoder.encode` to reject typo'd or missing fields instead of silently ignoring them ([#4560](https://github.com/solana-foundation/anchor/pull/4560)).
 - ts: Align TS `camelCase` conversion with Rust `heck` for digit-letter identifiers so generated client names match Rust identifiers ([#4571](https://github.com/solana-foundation/anchor/pull/4571)).
 - cli: Warn if `event-cpi` instruction is unreachable with custom discriminators ([#4614](https://github.com/solana-foundation/anchor/pull/4614)).
+- lang: Reduce cloning in `realloc` constraint when shrinking ([#4642](https://github.com/solana-foundation/anchor/pull/4642)).
 - syn: Remove `anyhow` ([#4640](https://github.com/solana-foundation/anchor/pull/4640)).
 - ts: Update `engines.node` to `>= 20.18` ([#4647](https://github.com/solana-foundation/anchor/pull/4647)).
 

lang/syn/src/codegen/accounts/constraints.rs

@@ -484,8 +484,8 @@ fn generate_constraint_realloc(
                 }
             } else {
                 let __lamport_amt = __field_info.lamports().checked_sub(__new_rent_minimum).unwrap();
-                **#payer.to_account_info().lamports.borrow_mut() = #payer.to_account_info().lamports().checked_add(__lamport_amt).unwrap();
-                **__field_info.lamports.borrow_mut() = __field_info.lamports().checked_sub(__lamport_amt).unwrap();
+                anchor_lang::Lamports::add_lamports(&#payer, __lamport_amt)?;
+                anchor_lang::Lamports::sub_lamports(&__field_info, __lamport_amt)?;
             }
 
             __field_info.resize(#new_space)?;

tests/realloc/programs/realloc/Cargo.toml

@@ -15,8 +15,5 @@ cpi = ["no-entrypoint"]
 default = []
 idl-build = ["anchor-lang/idl-build"]
 
-[profile.release]
-overflow-checks = true
-
 [dependencies]
 anchor-lang = { path = "../../../../lang" }