api: don't log errors for 404s (#69)

worm-emoji · web-flow · commit e40286fa73ed · 2022-09-07T11:56:19.000-07:00
diff --git a/api/root.go b/api/root.go
@@ -54,7 +54,7 @@ func (s *Server) GetRoot(w http.ResponseWriter, r *http.Request) {
 		&rr.Root,
 	)
 	if errors.Is(err, pgx.ErrNoRows) {
-		s.sendJSONError(r, w, err, http.StatusNotFound, "root not found for proofs")
+		s.sendJSONError(r, w, nil, http.StatusNotFound, "root not found for proofs")
 		return
 	} else if err != nil {
 		s.sendJSONError(r, w, err, http.StatusInternalServerError, "selecting root")
diff --git a/api/tree.go b/api/tree.go
@@ -189,7 +189,7 @@ func (s *Server) GetTree(w http.ResponseWriter, r *http.Request) {
 		&tr.Packed,
 	)
 	if errors.Is(err, pgx.ErrNoRows) {
-		s.sendJSONError(r, w, err, http.StatusNotFound, "tree not found for root")
+		s.sendJSONError(r, w, nil, http.StatusNotFound, "tree not found for root")
 		return
 	} else if err != nil {
 		s.sendJSONError(r, w, err, http.StatusInternalServerError, "selecting tree")

Original file line number	Diff line number	Diff line change
`@@ -54,7 +54,7 @@ func (s Server) GetRoot(w http.ResponseWriter, r http.Request) {`
`54`	`54`	`&rr.Root,`
`55`	`55`	`)`
`56`	`56`	`if errors.Is(err, pgx.ErrNoRows) {`
`57`		`- s.sendJSONError(r, w, err, http.StatusNotFound, "root not found for proofs")`
	`57`	`+ s.sendJSONError(r, w, nil, http.StatusNotFound, "root not found for proofs")`
`58`	`58`	`return`
`59`	`59`	`} else if err != nil {`
`60`	`60`	`s.sendJSONError(r, w, err, http.StatusInternalServerError, "selecting root")`
Original file line number	Diff line number	Diff line change
`@@ -189,7 +189,7 @@ func (s Server) GetTree(w http.ResponseWriter, r http.Request) {`
`189`	`189`	`&tr.Packed,`
`190`	`190`	`)`
`191`	`191`	`if errors.Is(err, pgx.ErrNoRows) {`
`192`		`- s.sendJSONError(r, w, err, http.StatusNotFound, "tree not found for root")`
	`192`	`+ s.sendJSONError(r, w, nil, http.StatusNotFound, "tree not found for root")`
`193`	`193`	`return`
`194`	`194`	`} else if err != nil {`
`195`	`195`	`s.sendJSONError(r, w, err, http.StatusInternalServerError, "selecting tree")`