royaltyBPS isn't public, but royaltyInfo is callable, and it returns a royaltyAmount equal to the passed in _salePrice * royaltyBPS / 10_000.
Assuming a smallest royalty of 0.1%, if the sale price passed in is less than 1000, then the royaltyAmount will be less than 1, and since it's a uint256, its value is 0.
To avoid returning 0 when the royalty should be greater than 0, and in fact the royaltyBPS is greater than 0 in the contract, we can pass in a _salePrice of 10000 to reconstruct the royaltyBPS value. We can then calculate the royaltyInfo based on the actual sale price off chain. Therefore this is not critical, but the royaltyInfo call is misleading and can result in unexpected results.
royaltyBPSisn't public, butroyaltyInfois callable, and it returns aroyaltyAmountequal to the passed in_salePrice * royaltyBPS / 10_000.Assuming a smallest royalty of 0.1%, if the sale price passed in is less than 1000, then the
royaltyAmountwill be less than 1, and since it's a uint256, its value is 0.To avoid returning 0 when the royalty should be greater than 0, and in fact the
royaltyBPSis greater than 0 in the contract, we can pass in a_salePriceof 10000 to reconstruct theroyaltyBPSvalue. We can then calculate theroyaltyInfobased on the actual sale price off chain. Therefore this is not critical, but theroyaltyInfocall is misleading and can result in unexpected results.