Merge pull request #73 from ourzora/steve-fix-mime-type-for-manifold

fix: mime type fetching for manifold

Author: Steven Jiang

docs/changelog.md

@@ -1,5 +1,9 @@
 # Changelog
 
+## v0.1.4
+
+- bug fix: parse mime type for Manifold NFT metadata
+
 ## v0.1.3
 
 - bug fix: add a type check to `should_parse_token()` in `OpenseaParser` to validate that `raw_data` is a `dict`

docs/index.md

@@ -1,6 +1,6 @@
 # Getting Started
 
-Documentation for version: **v0.1.3**
+Documentation for version: **v0.1.4**
 
 ## Overview
 

offchain/constants/providers.py

@@ -3,3 +3,4 @@
 
 class RPCProvider(StringEnum):
     CLOUDFLARE_MAINNET = "https://cloudflare-eth.com"
+    LLAMA_NODES_MAINNET = "https://eth.llamarpc.com"

offchain/metadata/fetchers/metadata_fetcher.py

@@ -100,5 +100,6 @@ def fetch_content(self, uri: str) -> Union[dict, str]:
                 return res.json()
             else:
                 return res.text
+
         except Exception as e:
             raise Exception(f"Don't know how to fetch metadata for {uri=}. {str(e)}")

offchain/metadata/parsers/catchall/default_catchall.py

@@ -78,16 +78,16 @@ def get_image_details(self, raw_data: dict) -> Optional[MediaDetails]:
         if not image_uri:
             return None
         details = MediaDetails(uri=image_uri, size=None, sha256=None, mime_type=None)
-        if isinstance(raw_data.get("image_details"), dict):
-            details.size = raw_data["image_details"].get("size")
-            details.sha256 = raw_data["image_details"].get("sha256")
-            return details
         try:
             content_type, size = self.fetcher.fetch_mime_type_and_size(image_uri)
-            details.mime_type = content_type
             details.size = size
+            details.mime_type = content_type
         except Exception:
             pass
+
+        if isinstance(raw_data.get("image_details"), dict):
+            details.size = raw_data["image_details"].get("size")
+            details.sha256 = raw_data["image_details"].get("sha256")
         return details
 
     def get_content_uri(self, raw_data: dict):
@@ -102,17 +102,15 @@ def get_content_details(self, raw_data: dict) -> Optional[MediaDetails]:
         if not content_uri:
             return None
         details = MediaDetails(uri=content_uri, size=None, sha256=None, mime_type=None)
-        if isinstance(raw_data.get("animation_details"), dict):
-            details.size = raw_data["animation_details"].get("size")
-            details.sha256 = raw_data["animation_details"].get("sha256")
-            return details
         try:
             content_type, size = self.fetcher.fetch_mime_type_and_size(content_uri)
-            details.mime_type = content_type
             details.size = size
+            details.mime_type = content_type
         except Exception:
             pass
-
+        if isinstance(raw_data.get("animation_details"), dict):
+            details.size = raw_data["animation_details"].get("size")
+            details.sha256 = raw_data["animation_details"].get("sha256")
         return details
 
     def parse_metadata(self, token: Token, raw_data: dict, *args, **kwargs) -> Optional[Metadata]:

offchain/web3/jsonrpc.py

@@ -29,7 +29,7 @@ def __init__(
         self.sess.mount("https://", adapter)
         self.sess.mount("http://", adapter)
         self.sess.headers = {"Content-Type": "application/json"}
-        self.url = provider_url or RPCProvider.CLOUDFLARE_MAINNET
+        self.url = provider_url or RPCProvider.LLAMA_NODES_MAINNET
 
     def __payload_factory(self, method: str, params: list[Any], id: int) -> RPCPayload:
         return {"method": method, "params": params, "id": id, "jsonrpc": "2.0"}

pyproject.toml

@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "offchain"
-version = "0.1.3"
+version = "0.1.4"
 description = "Open source metadata processing framework"
 authors = ["Zora eng <[email protected]>"]
 readme = "README.md"