Skip to content

Conversation

@ericli
Copy link
Contributor

@ericli ericli commented Aug 28, 2025

Description

Signing with the account instead of the account address in the tradecoin api

Motivation and Context

I'm facing an issue where I cannot use my local signed account. I noticed that we sign using the account address instead of the authed account.

Does this change the ABI/API?

  • This changes the ABI/API

What tests did you add/modify to account for these changes

Types of changes

  • [x ] Bug fix (non-breaking change which fixes an issue)
  • New module / feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • [x ] My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I added a changeset to account for this change

Reviewer Checklist:

  • My review includes a symposis of the changes and potential issues
  • The code style is enforced
  • There are no risky / concerning changes / additions to the PR

@iainnash
Copy link
Collaborator

iainnash commented Sep 1, 2025

Good catch — taking a look on Tuesday

@iainnash iainnash self-requested a review September 5, 2025 19:44
@iainnash iainnash merged commit 8e60d2f into ourzora:main Sep 5, 2025
2 checks passed
@J3698
Copy link

J3698 commented Sep 8, 2025

big fan of this one

iainnash added a commit that referenced this pull request Sep 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants